Remove deprecated parallel corpus analysis - #1053
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
+ Coverage 72.75% 72.79% +0.04%
==========================================
Files 392 390 -2
Lines 21741 21715 -26
Branches 2824 2824
==========================================
- Hits 15817 15808 -9
+ Misses 4801 4785 -16
+ Partials 1123 1122 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Enkidu93
approved these changes
Sep 30, 2026
Enkidu93
left a comment
Collaborator
There was a problem hiding this comment.
@Enkidu93 reviewed 11 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
Enkidu93
approved these changes
Sep 30, 2026
Enkidu93
left a comment
Collaborator
There was a problem hiding this comment.
Exciting!
@Enkidu93 made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1015
I kept the
MigrateTargetQuoteConventionMongo Migration, as removing it broke schema versioning (we could make it a null migration, but I think it is healthy to keep migrations as-is just in case an old database version is restored for example), but removed the test as it is stable code and is dependent on the classes removed by this PR.I have tested this PR with Scripture Forge and the ApiExample, and it works without issue with Serval.Client 1.20.
This change is