Skip to content

Remove deprecated parallel corpus analysis - #1053

Merged
pmachapman merged 1 commit into
mainfrom
remove_parallel_corpus_analysis
Sep 30, 2026
Merged

pmachapman merged 1 commit into
mainfrom
remove_parallel_corpus_analysis

Conversation

@pmachapman

@pmachapman pmachapman commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #1015

I kept the MigrateTargetQuoteConvention Mongo Migration, as removing it broke schema versioning (we could make it a null migration, but I think it is healthy to keep migrations as-is just in case an old database version is restored for example), but removed the test as it is stable code and is dependent on the classes removed by this PR.

I have tested this PR with Scripture Forge and the ApiExample, and it works without issue with Serval.Client 1.20.


This change is Reviewable

@pmachapman
pmachapman requested a review from Enkidu93 September 30, 2026 19:28
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.79%. Comparing base (0daa196) to head (5eceaf2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
+ Coverage   72.75%   72.79%   +0.04%     
==========================================
  Files         392      390       -2     
  Lines       21741    21715      -26     
  Branches     2824     2824              
==========================================
- Hits        15817    15808       -9     
+ Misses       4801     4785      -16     
+ Partials     1123     1122       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmachapman
pmachapman requested a review from ddaspit September 30, 2026 19:30

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 11 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

@Enkidu93 made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

@pmachapman
pmachapman removed the request for review from ddaspit September 30, 2026 20:11
@pmachapman
pmachapman merged commit 231bcba into main Sep 30, 2026
2 checks passed
@pmachapman
pmachapman deleted the remove_parallel_corpus_analysis branch September 30, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated SourceQuoteConvention

3 participants