Skip to content

Migrate PreTranslate.Refs and WordAlignmentRefs to TargetRefs - #1056

Merged
Enkidu93 merged 1 commit into
mainfrom
remove_pretranslationdto_refs
Oct 1, 2026
Merged

Enkidu93 merged 1 commit into
mainfrom
remove_pretranslationdto_refs

Conversation

@pmachapman

@pmachapman pmachapman commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #1017

Adding the WordAlignment migrator is probably overkill, as I am not aware of any word alignment objects on live, QA, or internal QA, but it is useful for completeness I guess.


This change is Reviewable

@pmachapman
pmachapman requested a review from Enkidu93 September 30, 2026 22:41
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.83%. Comparing base (231bcba) to head (5049591).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
+ Coverage   72.79%   72.83%   +0.03%     
==========================================
  Files         390      391       +1     
  Lines       21715    21741      +26     
  Branches     2824     2824              
==========================================
+ Hits        15808    15834      +26     
  Misses       4785     4785              
  Partials     1122     1122              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 19 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/Serval/src/Serval.WordAlignment/Configuration/MongoMigrations.cs line 13 at r1 (raw file):

                    "$set",
                    new BsonDocument(
                        "targetRefs",

I'm realizing that with the update to use the USFM versification conversion feature, we no longer use SourceRefs - is that correct? I think we should keep them for now, but this just brought that to my attention. I still think there's a chance we may want to tweak how that feature works in which case we may want the source refs.

@Enkidu93
Enkidu93 merged commit 30d2b88 into main Oct 1, 2026
1 of 2 checks passed
@Enkidu93
Enkidu93 deleted the remove_pretranslationdto_refs branch October 1, 2026 18:38
@pmachapman

Copy link
Copy Markdown
Collaborator Author

I'm realizing that with the update to use the USFM versification conversion feature, we no longer use SourceRefs - is that correct? I think we should keep them for now, but this just brought that to my attention. I still think there's a chance we may want to tweak how that feature works in which case we may want the source refs.

@Enkidu93 Hmm looks that way. Could be prudent to create an issue to deprecate or remove them in future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated PretranslationDto.Refs

3 participants