Migrate PreTranslate.Refs and WordAlignmentRefs to TargetRefs - #1056
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1056 +/- ##
==========================================
+ Coverage 72.79% 72.83% +0.03%
==========================================
Files 390 391 +1
Lines 21715 21741 +26
Branches 2824 2824
==========================================
+ Hits 15808 15834 +26
Misses 4785 4785
Partials 1122 1122 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 19 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
src/Serval/src/Serval.WordAlignment/Configuration/MongoMigrations.cs line 13 at r1 (raw file):
"$set", new BsonDocument( "targetRefs",
I'm realizing that with the update to use the USFM versification conversion feature, we no longer use SourceRefs - is that correct? I think we should keep them for now, but this just brought that to my attention. I still think there's a chance we may want to tweak how that feature works in which case we may want the source refs.
@Enkidu93 Hmm looks that way. Could be prudent to create an issue to deprecate or remove them in future? |
Fixes #1017
Adding the WordAlignment migrator is probably overkill, as I am not aware of any word alignment objects on live, QA, or internal QA, but it is useful for completeness I guess.
This change is