[Core] Merge Context into BaseContext - #6266
Open
damienmarchal wants to merge 3 commits into
Open
Conversation
- BaseContext is now a concrete class with Data members (is_activated, worldGravity_, dt_, time_, animate_, d_isSleeping, d_canChangeSleepingState) - All Context methods implemented in BaseContext - Node now inherits directly from BaseNode and BaseContext (instead of Context) - Context class kept as compatibility layer, inheriting from BaseContext - Updated includes in Contact.h, UniformMass.inl, VisualStyle.cpp, Main.cpp - Fixed casts in Node.cpp to use BaseContext instead of Context Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
damienmarchal
added
pr: status to review
damienmarchal
added
the
pr: AI-aided
damienmarchal
changed the title
damienmarchal
added
the
pr: breaking
damienmarchal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Context class is the only implementation of BaseContext.
This extra layer is probably over-engineered, so I merge the two.
Ideally BaseContext should have been merged down into Context.... but given that it would generate a huge amount of code change I prefer to merge Context up in BaseContext.
[ci-depends-on https://github.com/https://github.com/sofa-framework/SofaPython3/pull/636]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if