Skip to content

fix: publish authentication client choices atomically - #8275

Merged
danielkov merged 3 commits into
mainfrom
fix/atomic-auth-client-publication
Oct 29, 2026
Merged

danielkov merged 3 commits into
mainfrom
fix/atomic-auth-client-publication

Conversation

@danielkov

@danielkov danielkov commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Publish OAuth bindings and typed authentication-client associations in the same transaction, and keep credential-header and Enterprise Managed Authorization choices synchronized during normal configuration changes.

Motivation

New or changed upstream configuration could remain unavailable until a migration or reconciliation ran. A failed association capture could also leave a successful binding write without its corresponding typed choice.

Impact

Enterprise Managed Authorization resource identifiers remain exact throughout configuration and selection. URLs that differ by a trailing slash no longer share authentication choices.

Technical details

One transaction and lock contract

Use a consistent organization, project, source, server, and client lock order across configuration writers, metadata updates, and administrator actions. Keep synchronization with the originating write so failures roll back the binding rather than publishing incomplete configuration.

Retire stale derived links and credentials when their backing configuration leaves scope, while preserving administrator detaches and disabled clients. Configuration does not grant access automatically.

@danielkov
danielkov requested a review from a team as a code owner October 29, 2026 16:54
@changeset-bot

changeset-bot Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: deb3653

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@blacksmith-sh

This comment has been minimized.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 64 files

This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread server/internal/authclients/locking.go Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 68 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

@danielkov
danielkov added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 8109ca4 Oct 29, 2026
54 checks passed
@danielkov
danielkov deleted the fix/atomic-auth-client-publication branch October 29, 2026 19:23
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants