Allow explicit empty values for slice flags - #512
Closed
jaideeppyne wants to merge 1 commit into
Closed
jaideeppyne wants to merge 1 commit into
jaideeppyne wants to merge 1 commit into
Conversation
|
|
Author
|
Withdrawing because the required CLA cannot be completed as part of this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #222.
Treats
--flag=as an explicit non-nil empty slice for duration and numeric slice flags, matching the existing bool, string, IP, and CIDR slice behavior. An absent flag still preserves nil, empty, and populated defaults, while repeated slice flags retain their append semantics.The table-driven regression test covers every slice flag type.
Tests:
go test ./...,go vet ./...