Repository navigation
Remove the ASMX web service exporter from Spring.Web - #384
Merged
Merged
Conversation
Drops WebServiceExporter and WebServiceHandlerFactory (no replacement), the System.Web.Services references that only they needed, and their tests. The SpringAir example loses its BookingAgent web service, the *.asmx handler registrations and the stale Common.Logging configuration, and the unused SpringAir.Web.2003 and .2005 projects are deleted. BreakingChanges.txt item 4 now documents the removal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGkLQuAuUjvRjrU1AcTsmk Signed-off-by: Marko Lahma <marko.lahma@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGkLQuAuUjvRjrU1AcTsmk Signed-off-by: Marko Lahma <marko.lahma@gmail.com>
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Spring.Web's ASMX web service exporter for 4.0, with no replacement. Spring.Services, which held the ASMX client proxy, was already removed in #380.
Spring.Web.Services.WebServiceExporterandWebServiceHandlerFactory, the wholeWeb/Servicesfolder.System.Web.Servicesreference, which nothing else used.WebServiceExporterTests. The Spring.Core.Tests keep theirSystem.Web.Servicesreference: they use[WebMethod]as a sample attribute for proxy attribute copying.*.asmxhandler registrations, the stale Common.Logging config section and the "Booking Agent web service" link.SpringAir.Web.2003andSpringAir.Web.2005folders (259 files). They aren't inSpringAir.sln, and only the old readme referenced them.readme.txtforSpringAir.slnand SpringAir.Web.2010.Verification:
dotnet build Spring.Net.sln -c Debug: clean.Build.csleaves out every SpringAir solution from CompileExamples, and the website can't build with thedotnetCLI (MSB4249). I checked the edited Web.config and Services.xml are well-formed and reviewed the site's aspx and config files for leftover references.spring-revieweraccepted it.Follow-ups in the examples-cleanup PR:
Home.aspx.csoff Common.Logging.SpringAir.slnpath to the References project, which is wrong and was before this PR.Web.net30.config, which still maps*.asmxto the removed factory.🤖 Generated with Claude Code
https://claude.ai/code/session_01LGkLQuAuUjvRjrU1AcTsmk