Repository navigation
Examples: remove stale Common.Logging config and legacy Northwind web.config variants - #385
Merged
Merged
Conversation
- Remove the Common.Logging sectionGroup, <common> elements and binding redirects from the examples' App.config/Web.config files, along with the now dead log4net sections and the Northwind Config/Log4Net.xml files that only the Common.Logging adapter read. Delete App.config files left empty. - Port SpringAir.Web.2010 Home.aspx.cs to Microsoft.Extensions.Logging via Spring.LogManager and add the Microsoft.Extensions.Logging package to the web References project. Point SpringAir.sln at the existing SpringAir.Web.References.csproj and drop its unused System.Runtime.Remoting reference. - Delete the Northwind Web.net30.config/Web.net40.config files and the Conversation project's post-build step that overwrote Web.config with the net40 copy. Point the Conversation web at the NHibernate5 assemblies. - Put the actual first in constant-first Assert.That calls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGkLQuAuUjvRjrU1AcTsmk Signed-off-by: Marko Lahma <marko.lahma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the examples for 4.0. Only
examples/changes.Stale Common.Logging configuration. Spring.NET has logged through Microsoft.Extensions.Logging since 3.x, so no example uses Common.Logging any more.
commonsection group, the<common>element and the Common.Logging redirects from 12 config files:<log4net>sections and both NorthwindConfig/Log4Net.xmlfiles.Home.aspx.cs, the one C# user, toSpring.LogManager.GetLoggerand aLogDebugtemplate, with aMicrosoft.Extensions.Loggingreference in the site's References project.Northwind:
Web.net30.configandWeb.net40.configalternates in both web projects.Web.net40.configoverWeb.config. The two files were identical. The net40 copy still mapped*.asmxto theWebServiceHandlerFactoryremoved in Remove the ASMX web service exporter from Spring.Web #384.Web.configandWeb.xmlpointed at theSpring.Web.Conversation.NHibernate32assembly, which no longer exists. They now point atSpring.Web.Conversation.NHibernate5, and the type names are the same.SpringAir:
SpringAir.slnnow points at the References project file that actually exists (SpringAir.Web.References.csproj).System.Runtime.Remoting, which nothing used.Asserts: 9 asserts that put the expected value first now put the actual value first. They are in the Northwind, DataQuickStart and SpringAir tests.
Binding redirects: only Mvc5QuickStart has live redirects. Each matches the assembly version it builds against, so none changed.
Verification:
dotnetCLI:Home.aspx.cs, in a scratch net472 project against the built Spring.Core and Spring.Web.🤖 Generated with Claude Code
https://claude.ai/code/session_01LGkLQuAuUjvRjrU1AcTsmk