Repository navigation
Share MCP access with six-character invitation codes - #38
Merged
Merged
Conversation
|
To use Codex here, create an environment for this repo. |
This was referenced Oct 18, 2026
frahlg
marked this pull request as ready for review
October 18, 2026 18:04
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frahlg
force-pushed
the
codex/mcp-shared-access
branch
from
October 18, 2026 18:16
f073eeb to
3d6a6e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An owner can share their home with another person's MCP client through a six-character code such as
K7M-4PX. The recipient keeps its own key. Core grants only the intersection of the invitation and the client's request after Noise proves that key; the signed roster then completes ordinary OAuth/PKCE.Publish a strong Core invitation through TLS and return a unique alias valid for at most ten minutes. Keep bearer mappings in memory; keep only keyed digest reservations in SQLite so a restart cannot reuse an unexpired code for another home. The original browser cookie, Origin and separate attempt limits protect redemption. Cancellation, expiry and revocation still come from Core. A lost reply retries the same invitation. A Cloud restart requires the owner to republish it. The current deployment uses one OAuth process; multiple processes need routing for the in-memory mapping.
Paired Core protocol:
srcfl/ftw@codex/mcp-shared-access, pinned tov0.0.0-20261018181148-499d5de65104. Base this PR on setup PR #37. The canonical webapp and native contract copies use the same branch name. Merge after Core #1735 and its registry pair, then deploy with the common next Core beta.Validation:
GOWORK=offvet, the complete race suite, dev-tag suite and import checks pass on the combined final head f518a8d. Affected-package race tests pass for OAuth, MCP, store, keys and uplink. The TLS test covers publishing six characters, the recipient's own OAuth cookie/key, Noise proof, narrower rights, Keep/PKCE, an MCP read and 401 after revoke. Core's own tunnel test covers its proof/commit path separately. Tests also cover collision, restart reservations, lost replies, cancellation, key forgetting, and expired secret cleanup. No real ChatGPT or hardware session is claimed. Full CI passes on head 3d6a6e0, including vet, complete race tests, development-tag tests, import boundaries, fuzzing, MCP inspector and Linux builds. The actual consent template was rendered and inspected in a closed local browser fixture.go.workstays untracked and outside the Docker context.Production Go growth relative to #37: keys +45 lines, MCP +59, OAuth +370, store +79, uplink +15, command wiring +2. Tests excluded.