Repository navigation
Share assistant access with single-use invitation codes - #1735
Merged
Merged
Conversation
Summary
Testing
|
frahlg
force-pushed
the
codex/mcp-setup-contract
branch
from
October 18, 2026 17:32
c3c3711 to
0c66939
Compare
frahlg
force-pushed
the
codex/mcp-shared-access
branch
2 times, most recently
from
October 18, 2026 17:56
a4ce1d9 to
97012fd
Compare
frahlg
force-pushed
the
codex/mcp-setup-contract
branch
from
October 18, 2026 17:56
0c66939 to
1ec36be
Compare
frahlg
marked this pull request as ready for review
October 18, 2026 18:04
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frahlg
force-pushed
the
codex/mcp-setup-contract
branch
from
October 18, 2026 18:05
1ec36be to
af2b3b2
Compare
frahlg
force-pushed
the
codex/mcp-shared-access
branch
from
October 18, 2026 18:06
97012fd to
9f9a460
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97012fd509
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
frahlg
force-pushed
the
codex/mcp-shared-access
branch
from
October 18, 2026 18:12
9f9a460 to
499d5de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An owner can share a six-character code such as
K7M-4PXwith another person's assistant. The recipient keeps its own key and receives a separate connection the owner can remove. The code works once for at most ten minutes; access has its own expiry. Technical reads start on, while setup and control start off.Core stores the strong invitation's verifier and durable receipt. Noise must prove the recipient's key before Core consumes it and grants only the intersection of the invitation and client request. Recheck cancellation, owner state, expiry and signature at that point. Lost replies retry the same request; simultaneous claims cannot create two grants or revive revoked access. Agents cannot create sharing invitations merely because they may edit setup.
Add the owner view to Access and the shared wire vector. The short code maps to a strong invitation through Cloud; neither a code nor Cloud can grant owner rights. A Cloud restart can republish the same invitation without creating another Core grant. Explain who can use the code, when it ends and how to remove the resulting connection.
Pairs: srcfl/ftw-cloud#38, srcfl/ftw-webapp#100 and srcfl/ftw-app#95. Base setup: #1732. Merge the canonical registry copy immediately after Core, then coordinate the common next beta before Cloud deployment.
Validation: full
make verifypasses on head 229e0c1, including the final setup authority checks and merged sessions fix. Affected-package race suites, tunnel proof/claim tests, cancellation/retry/expiry cases, JavaScript Access tests and shared vectors pass. Registry copies match byte for byte. The owner approved the rendered Core sharing view; native Swift/JVM tests, build and light/dark/largest-text review pass. No real recipient, physical hardware or TestFlight release is claimed.Contract-pair: srcfl/ftw-webapp@codex/mcp-shared-access
Pending invitations now cancel permanently in the same saved snapshot when their owner loses access. Restoring the same phone cannot revive a code, including after restart or a proof already in progress. Every local creation reserves the current Cloud home before binding the verifier. The affected race tests pass for both regressions.