Skip to content

Add explicit MCP setup grants, typed calls and confirmed restart - #1732

Merged
frahlg merged 6 commits into
masterfrom
codex/mcp-setup-contract
Oct 18, 2026
Merged

frahlg merged 6 commits into
masterfrom
codex/mcp-setup-contract

Conversation

@frahlg

@frahlg frahlg commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Owners can grant an assistant setup access as a separate choice. Typed MCP calls read the complete setup schema, resume a draft, edit a field or list entry, validate, save the exact confirmed revision and request a separately confirmed restart. Everyday status, history and control keep their direct tools.

Keep the caller an agent. Recheck its live grant and request deadline after preparation, before every durable draft write and immediately before the Settings/receipt transaction. Revocation returns403; an ended request returns408. Both leave settings and receipts unchanged. A pending restart stays bound to the saved receipt, current configuration and live grant; an interrupted request cannot schedule it twice.

Use the running API through its late binding, including startup-unavailable behavior. Return the build's driver catalogue, price areas and runtime time zone. Maintain the product vision, roadmap and ADR 0011. Passive fresh-box claiming, vendor sign-in, guided interview metadata and forecast priors remain later increments; this PR does not claim them.

Pairs: srcfl/ftw-cloud#37, srcfl/ftw-webapp#99 and srcfl/ftw-app#92. Merge the canonical registry copy immediately after Core. Sharing follows in #1735. The base includes the merged sessions fix and 0.152.1 release source.

Validation: full make verify passes on combined head499d5de6, including this exact setup commit. Complete config/onboarding/API race suites and final gateway race regressions pass, covering late revocation, timeout during authority lookup, normalization, lost replies, credential identities and exact numbers. Production API-wrapper tests pass. The rendered Core consent view received the owner's approval; native tests/build and simulator review pass. No physical commissioning or actual client grant was tested.

@chatgpt-codex-connector

Copy link
Copy Markdown

Summary

Testing

  • ✅ node --test web/settings/tabs/access.test.mjs
  • ✅ git diff --check
  • ✅ make verify — all tests, vet, and builds passed; the suite reported its expected Docker release-context skip because no Docker daemon was available.

View task →

@frahlg
frahlg force-pushed the codex/mcp-onboarding branch from b041b26 to 1e904d9 Compare October 18, 2026 17:02
@frahlg
frahlg force-pushed the codex/mcp-onboarding branch from 1e904d9 to 682a230 Compare October 18, 2026 17:30
@frahlg
frahlg force-pushed the codex/mcp-setup-contract branch from c3c3711 to 0c66939 Compare October 18, 2026 17:32
@frahlg
frahlg force-pushed the codex/mcp-setup-contract branch from 0c66939 to 1ec36be Compare October 18, 2026 17:56
@frahlg
frahlg marked this pull request as ready for review October 18, 2026 18:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T18:07:50.863424Z 1ec36be Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@frahlg
frahlg force-pushed the codex/mcp-onboarding branch from 9c0cd9e to 00fba88 Compare October 18, 2026 18:05
@frahlg
frahlg force-pushed the codex/mcp-setup-contract branch from 1ec36be to af2b3b2 Compare October 18, 2026 18:05

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ec36be479

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread go/internal/api/api_agent_setup.go
@frahlg
frahlg changed the base branch from codex/mcp-onboarding to master October 18, 2026 18:11
@frahlg
frahlg merged commit 34e069c into master Oct 18, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant