Repository navigation
Add explicit MCP setup grants, typed calls and confirmed restart - #1732
Merged
Merged
Conversation
Summary
Testing
|
frahlg
force-pushed
the
codex/mcp-onboarding
branch
from
October 18, 2026 17:02
b041b26 to
1e904d9
Compare
frahlg
force-pushed
the
codex/mcp-onboarding
branch
from
October 18, 2026 17:30
1e904d9 to
682a230
Compare
frahlg
force-pushed
the
codex/mcp-setup-contract
branch
from
October 18, 2026 17:32
c3c3711 to
0c66939
Compare
frahlg
force-pushed
the
codex/mcp-setup-contract
branch
from
October 18, 2026 17:56
0c66939 to
1ec36be
Compare
frahlg
marked this pull request as ready for review
October 18, 2026 18:04
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frahlg
force-pushed
the
codex/mcp-onboarding
branch
from
October 18, 2026 18:05
9c0cd9e to
00fba88
Compare
frahlg
force-pushed
the
codex/mcp-setup-contract
branch
from
October 18, 2026 18:05
1ec36be to
af2b3b2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ec36be479
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owners can grant an assistant setup access as a separate choice. Typed MCP calls read the complete setup schema, resume a draft, edit a field or list entry, validate, save the exact confirmed revision and request a separately confirmed restart. Everyday status, history and control keep their direct tools.
Keep the caller an agent. Recheck its live grant and request deadline after preparation, before every durable draft write and immediately before the Settings/receipt transaction. Revocation returns403; an ended request returns408. Both leave settings and receipts unchanged. A pending restart stays bound to the saved receipt, current configuration and live grant; an interrupted request cannot schedule it twice.
Use the running API through its late binding, including startup-unavailable behavior. Return the build's driver catalogue, price areas and runtime time zone. Maintain the product vision, roadmap and ADR 0011. Passive fresh-box claiming, vendor sign-in, guided interview metadata and forecast priors remain later increments; this PR does not claim them.
Pairs: srcfl/ftw-cloud#37, srcfl/ftw-webapp#99 and srcfl/ftw-app#92. Merge the canonical registry copy immediately after Core. Sharing follows in #1735. The base includes the merged sessions fix and 0.152.1 release source.
Validation: full
make verifypasses on combined head499d5de6, including this exact setup commit. Complete config/onboarding/API race suites and final gateway race regressions pass, covering late revocation, timeout during authority lookup, normalization, lost replies, credential identities and exact numbers. Production API-wrapper tests pass. The rendered Core consent view received the owner's approval; native tests/build and simulator review pass. No physical commissioning or actual client grant was tested.