Repository navigation
Add durable setup drafts and a checked save receipt - #1731
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b49e6f109e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
frahlg
force-pushed
the
codex/mcp-onboarding
branch
from
October 18, 2026 17:02
b041b26 to
1e904d9
Compare
frahlg
changed the base branch from
codex/persistent-lan-login-20261018
to
master
October 18, 2026 17:02
frahlg
force-pushed
the
codex/mcp-onboarding
branch
from
October 18, 2026 17:30
1e904d9 to
682a230
Compare
frahlg
force-pushed
the
codex/mcp-onboarding
branch
from
October 18, 2026 18:05
9c0cd9e to
00fba88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An assistant can keep an unfinished home setup on the box without changing live settings after each answer. Add the complete typed configuration schema, durable drafts, revision and checksum checks, validation, and a save receipt committed in the same SQLite transaction as Settings.
Validation returns normalized fields under a new revision and checksum for the user to review. The final save compares the exact portable configuration after Settings normalization, before writing settings or its receipt. Drafts, Settings saves, reloads and recovery exports retain exact integer driver identifiers; an unrepresentable number fails with its field path.
Masked list edits preserve credentials through renamed and reordered drivers. The box assigns credential identities; clients cannot substitute their own. Replies distinguish saved settings, applied settings, pending restart and hardware verification. House-password changes retain their own action.
ADR 0011 plans passive first-run claiming, the setup conversation, sharing, optional forecast priors and public client entry. This foundation alone does not enable MCP writes, fresh-box pairing, sharing or forecast priors. Typed MCP setup follows in #1732 and sharing in #1735.
Validation: complete config/onboarding/API race suites, normalization and secret/path regressions, exact-number save/reload/export tests, and full
make verifypass. An independent source and UX reviewer checked the fixes. No physical site setup was tested.