Repository navigation
fix(control): the hourly import ceiling reports import_limit, not fuse_limit - #1783
Conversation
…e_limit Core folded the clock hour's import ceiling into the EV cap and the battery allocator under the fuse's name. A car held back by the hour's budget said fuse_limit, a boost it stopped said "Fuse protection", and the web page and apps blamed the main fuse while the phases were low. EVFuseBudget now records which limit left less room at each site reading, and EVLimitReason names it. The loadpoint reads it once per tick with the cap (SetFuseLimitReason) and labels a capped command import_limit or fuse_limit. The allocator marks FuseSaturatedByImport when the hour's limit is the ceiling it hit, and the boost stops with import_limit_block. fuse_limit now means the main fuse alone; the web page says so and gives the hour's limit its own words. The site simulation's new row is a night with a 6 kW hourly ceiling, a heavy first 50 minutes, a Core restart at 02:09 and phases at 1.5 A near the end of the hour. On master the idle car says fuse_limit; now it says import_limit and starts within 16 s of the new hour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb55a26b9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| step := evPhaseMarginA * s.SiteFuseVoltage * pool.phases | ||
| // The label follows whichever limit leaves less room. | ||
| lim.byImport = math.Min(r.limitW, r.riseW) < r.fuseW |
There was a problem hiding this comment.
When an idle car plugs in after a low-import part of the hour, limitW and riseW can both exceed the fuse ceiling, while the separate start ceiling still blocks charging. For example, with a 7.5 kW import setting, ample accumulated hourly slack, an 8 kW house load and a 25 A three-phase fuse, this comparison sets byImport to false. However, stepEVIdleStart rejects the start because startLevelW is capped at PeakImportCeilingW, leaving negative import headroom despite sufficient fuse headroom. The updated UI consequently says “Paused by the main fuse” when the import policy is responsible. Include the binding idle-start constraint when selecting the reason.
Useful? React with 👍 / 👎.
…imit Review of #1783 (Codex): after a quiet part of the hour, the hour's limits can sit above what the fuse allows, so the label compared them and said fuse_limit. An idle car is then kept off by the ceiling's own start test, which caps the start level at the ceiling itself. Under a measured hour the idle start now names the limit by that test: the start level against this reading, and import_limit when the dwell's mean import fails it. TestImportCeilingStartTestSaysImportLimit: 40 quiet minutes under a 7.5 kW ceiling, then an 8 kW house and a car plugged in. It said fuse_limit; it says import_limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review of #1783: the field case as a test. A 7.5 kW hourly ceiling, a 25 A fuse, a light first half hour and a car plugged in at 22:40 beside 6 kW, and 8 kW, of house load. Every tick to 23:00 is checked; on cb55a26 it said fuse_limit from 22:40:01, with 1a79330 it says import_limit throughout. The site simulation's last-quarter rule now states its 15 minutes instead of copying importHourRiseMinLeft, so a wrong constant shows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 participant
Step 5 of the fuse rule in Fredrik's review of 21 October 2026: the hourly import ceiling is its own limit, named
import_limit, neverfuse_limit. The second of three PRs, independent of #1782 (direction of phase current); the third makes fuse protection one function.Problem
Core folded the clock hour's import ceiling (
peak_import_ceiling_w) into the EV cap and the battery allocator under the fuse's name:commanded_reason: fuse_limit;fuse_safety_block);fuse_limit.Near the end of a heavy hour the ceiling falls toward 0 while the phases are low, so the UI blamed the main fuse at the wrong time. This is the most likely cause of last night's case on an Easee Cloud + SolarEdge site (car idle overnight,
goal_at_riskat 04:25, UI blamed the main fuse with low phases).Change
EVFuseBudgetrecords which limit left less room at each site reading (evMeterLimit.byImport);EVLimitReasonnames it.SetFuseLimitReason, wired in main.go and the site simulation) and labels a capped commandimport_limitorfuse_limit. Manual-hold status and control feedback treatimport_limitas a limit, likefuse_limit.FuseSaturatedByImportwhen the hour's limit is the ceiling it hit. The boost then stops withimport_limit_block.fuse_limitnow means the main fuse ("Limited by the main fuse");import_limitgets "Limited by the hourly import limit" and its own sentences in the EV card and boost list.Not a registry name:
commanded_reasonand the feedback reasons are not incontract/registry.yaml, so there is no contract pair. Old clients show unknown reasons as "The box reports “import_limit”, which this version cannot describe." Follow-ups: copyweb/control-feedback.jsinto ftw-webapp'ssrc/vendor/ftw/, addimport_limitto ftw-webappsrc/lib/format/ev.ts, and add it to the iOSControlFeedback.swiftandEV.swift.Deleted: nothing of size; this PR splits a label. It adds no settings.
Overlap: #1537 (draft) edits the status list in
api_control_feedback.goand the title table inweb/control-feedback.js.import_limitsits on its own lines, so neither PR rewrites the other's lines.Site simulation, before → after
New row: end of a heavy hour, low phases. Night from 02:00, 6 kW hourly ceiling, house at 10 A per phase until 02:50, then 1.5 A, Charge now, Core restart at 02:09. The plant's own hour model expects no start in an hour's last quarter, as Core does.
fuse_limit(fails)import_limitAll other rows unchanged.
Review fix (Codex P2, second commit): after a quiet part of the hour its limits can sit above what the fuse allows, while the ceiling's own start test still keeps an idle car off. The idle start now names the limit by that test.
TestImportCeilingStartTestSaysImportLimit(40 quiet minutes, then an 8 kW house under a 7.5 kW ceiling) saidfuse_limitbefore the fix.Tests:
TestImportCeilingSaysImportLimitNotFuse(the #1674 site: hour's ceiling →import_limit; fuse →fuse_limit),TestJointFuseAllocatorNamesTheHoursImportLimit,TestCommandedReasonImportLimit(cap 0 and 6,210 W over a hold), web tests for the new words.Evidence
go test -p 2 ./internal/control ./internal/loadpoint ./internal/api ./cmd/ftw: passnpm test: 868 passmake verify(withGOFLAGS=-p=2): passThe web copy changes need a person to look at them in a browser; I have not rendered them. Real-hardware evidence is still needed: a site with
peak_import_ceiling_wset, at the end of a heavy hour.🤖 Generated with Claude Code