Repository navigation
feat(vector): Upgrade to 0.58.0 #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
51dd18e
b1bc035
46082e2
5064268
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #!/usr/bin/env bash | ||
| # | ||
| # Usage: vector-with-env-var-interpolation <vector-options> | ||
| # | ||
| # Starts Vector with the interpolation of environment variables in the | ||
| # configuration files enabled. All arguments are forwarded to Vector unchanged. | ||
| # | ||
| # Only use this script in a controlled environment where the configuration | ||
| # files and the environment variables are trusted. Start the `vector` binary | ||
| # directly otherwise. | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| # Vector disabled the interpolation of environment variables in configuration | ||
| # files by default and considers it dangerous because it allows a configuration | ||
| # file to read arbitrary environment variables, like secrets which were meant | ||
| # for another process. The Stackable Data Platform relies on this interpolation | ||
| # to inject deployment-specific values into the Vector configuration, like log | ||
| # directories and file names, log levels, information about the role group the | ||
| # pod belongs to, and the address of the Vector aggregator. It also generates | ||
| # the configuration files itself, so the option can safely be enabled here. | ||
| exec /usr/local/bin/vector --dangerously-allow-env-var-interpolation "$@" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What just crossed my mind: I think we let config-utils run on most config files already (some we didn't get to yet). It offers a consistent way of injection env vars and file contents across the platform.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to add YAML support to config-utils. Ideally, config-utils would parse the file first and only then interpolate the environment variables, so that environment variable values cannot alter the document structure (see also vectordotdev/vector#26475).
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, YAML sadly looks like more effort than XML and properties |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| mirror = "https://github.com/stackabletech/vector.git" | ||
| base = "cf8de830c6060629092397fd2334fc0f0219363a" | ||
| base = "2bcad9bbb84e201dcfd58c22b1f779290101b728" |
Uh oh!
There was an error while loading. Please reload this page.