Repository navigation
Stop rendering the empty search modal on every page - #458
Merged
Merged
Conversation
The Bootstrap theme included the search modal on every page, which added a second h1 next to the page heading. Nothing opens the modal and its body is empty, so the base template no longer includes it. The searchModal block stays available for templates that need the modal. The modal title is now an h2, so including it never adds a second h1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe Bootstrap base template no longer renders an unused search modal on every page, while retaining an override hook for consumers that need it; the modal title is also changed to h2 to avoid adding a second h1 when included. Flow diagram for optional search modal renderingflowchart TD
BaseTemplate[Bootstrap Base Template] --> SearchModalBlock{searchModal block}
SearchModalBlock -->|default| NoModal[Render page without search modal]
SearchModalBlock -->|theme or template override| SearchModal[Include SearchModal.html.twig]
SearchModal --> ModalHeading[Render modal title as h2]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
tijsverkoyen
approved these changes
Oct 13, 2026
jonasdekeukelaere
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bootstrap theme included the search modal on every page. Its visually hidden title is an h1, so every page had a second h1 next to the page heading. Nothing opens the modal and its body is empty.
searchModalblock stays available, so a theme or template that needs the modal can override it and includeSearchModal.html.twig.🤖 Generated with Claude Code
Summary by Sourcery
Make the Bootstrap search modal opt-in and preserve valid heading hierarchy when it is used.
Bug Fixes:
Enhancements: