Skip to content

Stop rendering the empty search modal on every page #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonasdekeukelaere merged 1 commit into from
Oct 14, 2026
Merged

Stop rendering the empty search modal on every page #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Frontend/Themes/Bootstrap/src/Layout/Templates/Base.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,8 @@
{% include "Core/Layout/Templates/PrivacyConsentDialog.html.twig" %}
{% endblock %}

{% block searchModal %}
{% include "Core/Layout/Templates/SearchModal.html.twig" %}
{% endblock %}
{# Override this block to include Core/Layout/Templates/SearchModal.html.twig where needed #}
{% block searchModal %}{% endblock %}

{# Site wide HTML #}
{% block htmlFooter %}
Expand Down
2 changes: 1 addition & 1 deletion src/Frontend/Themes/Bootstrap/src/Layout/Templates/SearchModal.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="modal-dialog modal-fullscreen-md-down modal-dialog-centered">
<div class="modal-content">
<div class="modal-header">
<h1 class="modal-title fs-5 visually-hidden" id="topModalLabel">Modal title</h1>
<h2 class="modal-title fs-5 visually-hidden" id="topModalLabel">Modal title</h2>
<button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
</div>
<div class="modal-body d-flex flex-column justify-content-center">
Expand Down
Loading