Repository navigation
Load Ethereum proof dependencies only when building a proof - #18
Merged
Merged
Conversation
Member
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing syscoinjs-lib currently initializes eth-proof and its legacy Merkle-trie/Elliptic dependencies even for ordinary wallet operations. Load the three proof-only dependencies when buildEthProof is called instead, preserving the exported API, automatic proof construction for assetAllocationMint, and existing constructor/request error handling.
Adds isolated-process regressions for imports with unavailable proof dependencies, first-use loading and constructor rejection, and the existing returned-error behavior for failed proof requests. The eager-loading regressions fail on the base revision and pass with this change.
Validation: 642 offline unit assertions passed, including the existing mint and transaction fixtures; Standard lint passed on Node 26.12.1. The full unit suite ran with the repository network fence enabled.
This changes runtime initialization only. The proof dependencies remain installed, audit findings remain visible, and bundlers may still include their code. No dependency versions, package version, or proof algorithms change.