Repository navigation
fix(platform): share folder-name validation in create and rename - #4252
Merged
Merged
Conversation
Contributor
Author
|
Independent review: accept at exact head Evidence reviewed:
Unrun: the targeted jsdom suite could not reach assertions in this checkout because Vite loaded |
yannickmonney
force-pushed
the
fix/folder-name-validation
branch
from
October 9, 2026 02:40
2da4cc4 to
37a7648
Compare
yannickmonney
enabled auto-merge
October 9, 2026 02:40
yannickmonney
force-pushed
the
fix/folder-name-validation
branch
5 times, most recently
from
October 9, 2026 15:00
4506641 to
ac2f3e9
Compare
yannickmonney
enabled auto-merge (squash)
October 9, 2026 22:14
yannickmonney
force-pushed
the
fix/folder-name-validation
branch
2 times, most recently
from
October 9, 2026 23:49
1ccb00a to
a40be4a
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2026
yannickmonney
force-pushed
the
fix/folder-name-validation
branch
from
October 10, 2026 09:04
a40be4a to
c774ba0
Compare
yannickmonney
force-pushed
the
fix/folder-name-validation
branch
from
October 11, 2026 00:04
c774ba0 to
747832c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
FOLDER_NAME_INVALIDrefusal also maps to the name field without clearing or disabling the draft; corrected retries succeed.documents.folder.invalidNameandfolder.nameRequired, already translated in EN/DE/FR with de-CH fallback. No new or untranslated strings.Verification
Whole-platform tests, whole-workspace types and production checks are left to CI/authorized operators. Independent review requested separately; no self-acceptance or merge.
Closes #3629
Current-main rebase
Replayed the previously accepted source
b8cdf1cbb6c7492534d01e33ff95ef5810ef3b2bonto maind1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.Maintenance replay: preserves the accepted feature payload on current main 7d178ca. Includes the merged #4649 Knip cleanup and the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), which is still pending native merge on main. The fixed suite inventory keeps its discovery and source/compiled phase guards. Existing feature proof is retained; no fresh full-feature/full-workspace test or hosted-green claim. Native required checks remain mandatory.