Repository navigation
fix(platform): stage accepted task attachment metadata - #4283
yannickmonney wants to merge 1 commit into
Conversation
TALE-635 independent review — ACCEPT at source level onlyExact head: Evidence:
Independent light reproduction (installed Node v24.21.0, existing server config, one worker):
Environment correction: the author's missing OPEN MERGE GATE: the extended isolated PG/MinIO/native-door/actual-daemon real-byte lane is implemented and source-reviewed, UNRUN HERE. Named heavy-slot question No whole-platform suite/workspace tsc, independent TypeScript/SAST rerun, browser/native acceptance or CI evaluation. Pinned local Opengrep was uncached; no installation or SAST pass claimed. No CI rerun/cancel/wait, push, merge, card move or #4275 work. Root's 08:15Z rule applies: a blocking finding overrides ACCEPT until independently closed on the exact head with proof. Full source reasoning, exact patch/source copies, commands and raw reproduction/static logs: |
12598c9 to
a414cad
Compare
5a88a66 to
747a548
Compare
747a548 to
24ae728
Compare
What changed
TALE-617, bounded child B of #4101 / TALE-484. The parent remains open for
other follow-ups and rollout; this PR does not close #4101.
units in the review manifest, retaining the original display metadata.
on code-point boundaries. Existing hashed storage-ref directories isolate
distinct blobs even when normalized leaves share a prefix.
object's type with application/octet-stream fallback where required; task
display MIME is not forwarded into transfer headers.
the 20 MiB limit, live issuer/current grant, and pre/post-transfer checks.
production attachment/output service writers. No second transfer stack or
daemon, TTL, retention, durable audit, grant or opt-in change.
Verification
failures / 35 passes (blank MIME, 255-unit MIME, 241/255 ASCII and >240-byte
multibyte names, plus shared-prefix isolation).
discovery and integration-skip guards: 146 tests pass across 6 files with
installed Node 24.21.0, one worker, unchanged Vitest config.
cover the four changed files and both direct shim importers, with imports
resolved: zero diagnostics; not whole-workspace tsc.
excluded item, so this is not a claim of exhaustive analysis.
Open proof / environment limitations
(30 minutes, estimated additional peak disk 8 GiB, 20 GiB reserve plus growth).
New real-byte integration cases are implemented, not yet executed.
collect because the installed tree lacks eventsource-parser. Raw logs are
retained; no reinstall, cache wipe or configuration weakening attempted.
TALE-618 follows under the same shared-test owner; TALE-549 remains separate.
Current-main rebase
Replayed the previously accepted source
5a88a660669810906eff598585071ce0c0990780onto maind1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.Maintenance replay: preserves the accepted feature payload on current main 7d178ca. Includes the merged #4649 Knip cleanup and the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), which is still pending native merge on main. The fixed suite inventory keeps its discovery and source/compiled phase guards. Existing feature proof is retained; no fresh full-feature/full-workspace test or hosted-green claim. Native required checks remain mandatory.