Repository navigation
fix(platform): recover legal-hold matters reads without losing focus - #4327
Merged
Merged
Conversation
yannickmonney
force-pushed
the
fix/legal-hold-matters-read-failure
branch
from
October 9, 2026 02:15
532a3eb to
7b006dc
Compare
yannickmonney
enabled auto-merge
October 9, 2026 02:15
yannickmonney
disabled auto-merge
October 9, 2026 03:26
yannickmonney
force-pushed
the
fix/legal-hold-matters-read-failure
branch
from
October 9, 2026 12:46
7b006dc to
fa6db96
Compare
yannickmonney
enabled auto-merge
October 9, 2026 12:47
yannickmonney
force-pushed
the
fix/legal-hold-matters-read-failure
branch
from
October 9, 2026 14:07
fa6db96 to
cbbc26b
Compare
yannickmonney
force-pushed
the
fix/legal-hold-matters-read-failure
branch
from
October 9, 2026 15:02
cbbc26b to
f39e7eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed Legal Hold Matters read now uses the existing localized DataTable failure state and retry. Retrying moves focus to the named Matters section before the read starts, so removing the retry control keeps a useful focus destination. The shared focus handoff also preserves focus that another control acquires before its queued frame.
Rebased onto main
aba03419878bc46d4ec7ab7cf01d116a9e74b462; original query, filters, dialogs and localized labels remain. The recovery-hook generic changes types only. Coverage is recorded in the existing manual register.Validation: 106 distinct selected tests pass, with an independent 16-case subset on the exact head. The final original-source overlays fail five host focus cases and three shared frame-ownership cases while their controls pass. Full platform/UI types and configured scoped lint, format, manual, conflict, SAST and commit checks pass. Whole Knip still reports seven inherited main findings; no whole-repository green claim.
Chromium with the real component, query hooks and adapters plus synthetic HTTP answers reproduces original BODY focus loss, repaired section focus, background recovery and foreign-focus preservation. EN/DE/FR desktop and narrow layouts were observed. The hidden preview cannot prove foreground focus paint; assistive technology and a live authenticated backend remain unobserved. All seven native required checks and merge-group integration remain mandatory.
Closes #3836
Closes #3837
Closes #3838
Current-main rebase
Replayed the previously accepted source
fa6db96202e376d07a95e4046176075c4f0298e3onto maind1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.Maintenance replay: preserves the accepted feature payload on current main 7d178ca. Includes the merged #4649 Knip cleanup and the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), which is still pending native merge on main. The fixed suite inventory keeps its discovery and source/compiled phase guards. Existing feature proof is retained; no fresh full-feature/full-workspace test or hosted-green claim. Native required checks remain mandatory.