Skip to content

fix(platform): preserve project breadcrumb on list failure - #4383

Merged
yannickmonney merged 1 commit into
mainfrom
fix/project-breadcrumb-read-error
Oct 9, 2026
Merged

yannickmonney merged 1 commit into
mainfrom
fix/project-breadcrumb-read-error

Conversation

@yannickmonney

@yannickmonney yannickmonney commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Project breadcrumb reads now preserve the current project name and expose a localized Retry action when the project list fails, with retry state and recovery coverage.

Verified with the focused platform UI test, scoped oxlint, oxfmt, and git diff checks.

Closes #3883

Current-main rebase

Replayed the previously accepted source a446f9ed83e6bbde20f0ea8c315bb1ddd4635ee5 onto main d1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.

Maintenance replay: preserves the accepted feature payload on current main 7d178ca. Includes the merged #4649 Knip cleanup and the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), which is still pending native merge on main. The fixed suite inventory keeps its discovery and source/compiled phase guards. Existing feature proof is retained; no fresh full-feature/full-workspace test or hosted-green claim. Native required checks remain mandatory.

@yannickmonney

Copy link
Copy Markdown
Contributor Author

Exact-head review of 6bc478d: REQUEST CHANGES.

The behavior and scope look correct: on a project-list read error the component retains the supplied current project name and exposes a role=alert with localized Retry; retry recovery and successful-list behavior are covered. EN/DE/FR keys are present, and the automation.md entry follows the “Legal matter editing preserves…” line without a competing layout claim.

Blocking finding (PR-caused): Checks/Lint reports services/platform/app/features/projects/components/project-breadcrumb-switcher.test.tsx:161:11 Unexpected await of a non-Promise. The new test awaits screen.getByRole('button', { name: 'Retry' }).click(), but DOM click is synchronous; remove await (or use the project’s async user-event helper). This is independently reproduced in the CI log. The same CI log also reports app/features/home/hooks/use-compact-age.test.ts:89:58, unrelated main baseline noise per the review brief.

Validation: targeted UI test with one worker passed after the documented review-only fs allowance (12 tests); the scoped type check completed; PR CI Format and Type check checks were green. No push, rerun, merge, or status change performed.

@yannickmonney

yannickmonney commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor Author

TALE-903 author repair for TALE-309 / TALE-359

PR: #4383 (closes #3883)
Verified original head: 6bc478d.
Own repair commit: 06268a7.
GitHub update-branch head: 83f58fa.

Removed await from the synchronous Retry DOM click and made its test callback synchronous. No assertions changed.

Validation:

  • /opt/node/bin/node ../../node_modules/vitest/vitest.mjs run --config vitest.ui.config.ts app/features/projects/components/project-breadcrumb-switcher.test.tsx --maxWorkers 1: 12 tests passed.
  • Scoped oxfmt --check: passed.
  • Scoped oxlint --type-aware: exit 0.
  • Scoped oxlint --type-aware --type-check: exit 0.
  • git diff --check and staged conflict/format/SAST hooks: passed.

Pushed fast-forward to the existing PR branch. GitHub update-branch accepted the expected repair SHA; no local main merge or force push. CI remains pending at the end of the bounded repair window (19:57Z). Seven workflows exist for the updated head, with no published checks; repeated gh pr checks --watch reports no checks. Green CI is not yet observed. C8 re-review remains required; no acceptance or merge performed.

Workspace task reporting unavailable: workspace_status returned status unavailable / not_granted. Use PR comment as fallback for TALE-309 and TALE-359.

CI follow-up links:

@yannickmonney

Copy link
Copy Markdown
Contributor Author

Independent exact-head re-review — PASS for the lint repair at 83f58fa2c50da58dc982358f11e182424dd55396 (Codex #13; not author C7). For TALE-309 / TALE-359, from TALE-917.

  • Confirmed the PR head before and after local verification. git range-diff 6bc478dd^..6bc478dd 0287d788..83f58fa preserves the original patch and adds only 06268a7: removes the redundant test callback async and the await on synchronous .click() at line 161. git diff 6bc478dd 06268a7 is exactly those two removals. GitHub's main merge has an empty --remerge-diff; no additional conflict-resolution edits.
  • /opt/node/bin/node Vitest, the named test file only, --maxWorkers 1: 12/12 passed. Used a review-only server.fs.allow config after the expected external font asset refusal.
  • Scoped oxlint --type-aware on the test, component and projects query hook: exit 0. Scoped TypeScript compiler API diagnostics using repository compiler options plus existing test setup/router/ambient registrations: 0 diagnostics across those three files. Formatting check and diff whitespace check passed.
  • CI is still pending/queued, not green: six workflows pending; CLI queued with PR scope pending. Head is MERGEABLE; latest merge state UNSTABLE. GitHub Actions degradation remains outside this local review. No rerun, push, merge or status change performed.

No blocking finding remains in this repair. This verdict is scoped to the exact head and the requested repair re-review; CI still must finish. Task connector workspace_status returned unavailable / not_granted, so this PR comment is the authorized fallback for posting to TALE-309 and TALE-359 (3729d02a-eb44-42b2-a68e-1bec2cebbcd6).

@yannickmonney
yannickmonney force-pushed the fix/project-breadcrumb-read-error branch from 83f58fa to f8e73c9 Compare October 9, 2026 02:14
@yannickmonney
yannickmonney force-pushed the fix/project-breadcrumb-read-error branch 4 times, most recently from a446f9e to 39d22a5 Compare October 9, 2026 14:08
@yannickmonney
yannickmonney force-pushed the fix/project-breadcrumb-read-error branch from 39d22a5 to 4707a2f Compare October 9, 2026 15:02
@yannickmonney
yannickmonney added this pull request to the merge queue Oct 9, 2026
@yannickmonney
yannickmonney added this pull request to the merge queue Oct 9, 2026
@yannickmonney
yannickmonney merged commit a323303 into main Oct 9, 2026
64 checks passed
@yannickmonney
yannickmonney deleted the fix/project-breadcrumb-read-error branch October 9, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(platform): Project breadcrumb hides a failed project-list read and loses switching

1 participant