Repository navigation
fix(platform): preserve project breadcrumb on list failure - #4383
Conversation
|
Exact-head review of 6bc478d: REQUEST CHANGES. The behavior and scope look correct: on a project-list read error the component retains the supplied current project name and exposes a role=alert with localized Retry; retry recovery and successful-list behavior are covered. EN/DE/FR keys are present, and the automation.md entry follows the “Legal matter editing preserves…” line without a competing layout claim. Blocking finding (PR-caused): Checks/Lint reports services/platform/app/features/projects/components/project-breadcrumb-switcher.test.tsx:161:11 Unexpected await of a non-Promise. The new test awaits screen.getByRole('button', { name: 'Retry' }).click(), but DOM click is synchronous; remove await (or use the project’s async user-event helper). This is independently reproduced in the CI log. The same CI log also reports app/features/home/hooks/use-compact-age.test.ts:89:58, unrelated main baseline noise per the review brief. Validation: targeted UI test with one worker passed after the documented review-only fs allowance (12 tests); the scoped type check completed; PR CI Format and Type check checks were green. No push, rerun, merge, or status change performed. |
|
TALE-903 author repair for TALE-309 / TALE-359 PR: #4383 (closes #3883) Removed await from the synchronous Retry DOM click and made its test callback synchronous. No assertions changed. Validation:
Pushed fast-forward to the existing PR branch. GitHub update-branch accepted the expected repair SHA; no local main merge or force push. CI remains pending at the end of the bounded repair window (19:57Z). Seven workflows exist for the updated head, with no published checks; repeated gh pr checks --watch reports no checks. Green CI is not yet observed. C8 re-review remains required; no acceptance or merge performed. Workspace task reporting unavailable: workspace_status returned status unavailable / not_granted. Use PR comment as fallback for TALE-309 and TALE-359. CI follow-up links:
|
|
Independent exact-head re-review — PASS for the lint repair at
No blocking finding remains in this repair. This verdict is scoped to the exact head and the requested repair re-review; CI still must finish. Task connector |
83f58fa to
f8e73c9
Compare
a446f9e to
39d22a5
Compare
39d22a5 to
4707a2f
Compare
Project breadcrumb reads now preserve the current project name and expose a localized Retry action when the project list fails, with retry state and recovery coverage.
Verified with the focused platform UI test, scoped oxlint, oxfmt, and git diff checks.
Closes #3883
Current-main rebase
Replayed the previously accepted source
a446f9ed83e6bbde20f0ea8c315bb1ddd4635ee5onto maind1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.Maintenance replay: preserves the accepted feature payload on current main 7d178ca. Includes the merged #4649 Knip cleanup and the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), which is still pending native merge on main. The fixed suite inventory keeps its discovery and source/compiled phase guards. Existing feature proof is retained; no fresh full-feature/full-workspace test or hosted-green claim. Native required checks remain mandatory.