Repository navigation
fix(platform): report custom instructions toggle failures - #4403
yannickmonney wants to merge 1 commit into
Conversation
|
TALE-204 / TALE-359 dispatch report — LIGHT phase Implemented at Local validation passed: 37 focused UI tests, 99 focused server/guard/locale tests, scoped TypeScript, type-aware oxlint (2 files, 226 rules, no diagnostics), oxfmt, manual-register validation, conflict-marker check and targeted SAST (0 findings; the test file is excluded by existing scan rules). Chromium with local HTTP fixtures verified the actual component, reads, mutation hook and adapter: a 503 produces visible feedback, preserves the value, and permits a successful retry; no page errors. No production failure simulation is claimed. Automation coverage was registered and Visual evidence: reduced-motion analysis scored 100 with no defects across 25 elements. Normal-motion analysis flagged the shared toast entrance animation (score 70, three jank observations, zero dropped frames). That evidence is retained; the shared animation was not changed in this focused fix. Actions checks remain queued after watching; no rerun was requested (reported incident |
|
Independent exact-head review — Codex #8, not author Codex #7. PR #4403 / TALE-204 (closes #3665), reviewed head Verdict: no blocking findings in the change; local scoped checks pass. CI remains pending, stalled under incident The failed toggle now renders a destructive toast explicitly saying the preference was not changed. Verification with existing dependencies and
Register integration: Limits: simulated transport and rendered DOM tests, no live backend or real-browser announcement check; full workspace types/suites remain CI-owned. TALE-204 and TALE-359 ( |
6b32b4c to
8148dac
Compare
687ae95 to
d5cb56a
Compare
d5cb56a to
0d48deb
Compare
A failed Custom instructions switch save previously only logged to the console. It now shows one destructive notification saying the preference was not changed and inviting a retry, with safe refusal details from
failureDetail. The persisted switch value and instructions remain intact; successful saves still produce one success notification. New copy ships in EN/DE/FR, with de-CH fallback.Verification:
git merge-treeagainst 74 open PR heads found no new conflicts relative to main.CI status will be recorded below. Actions was reported stalled under incident
3q1yb5m7ltvb; no rerun will be requested. Independent nonauthor review remains required.Closes #3665
Current-main rebase
Replayed the previously accepted source
c5aa62f9a2aaea1a3b9083c684329f711bf37df5onto maind1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.Maintenance replay: preserves the accepted feature payload on main fd277c4, including merged #4649, #4650 and #4655. Retains the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), pending native merge on main. The #4282 task-register union, where applicable, retains the accepted feature row and current-main rows. Existing behavioral evidence remains recorded above; no fresh full-feature/full-workspace or hosted-green claim. All seven native required contexts and full merge-group validation remain mandatory.