Repository navigation
fix(platform): keep skill editor visible after saving - #4405
yannickmonney wants to merge 1 commit into
Conversation
|
TALE-186 / TALE-359 dispatch report (PR-comment fallback) Implemented #3642 in Verification: 44 tests pass across six targeted skill suites with one worker; the new real-parent/hooks/React Query/HTTP regressions fail on unchanged main for the normalized no-op and detail-first refresh, and pass with this fix. Both refresh orders, refused-save draft retention, and untouched reopen without PUT are covered. Scoped types, type-aware oxlint, oxfmt, manual register and conflict-marker gates pass. Chromium confirms no-op and changed saves remain visible and clean; visual analyzer baseline 100 / final 100, zero defects. The register anchor is unique across 75 open PR heads; merge-tree shows no newly introduced conflicts (31 heads already conflict with main). CI watch: 21 checks pending, seven expected candidate-source skips, no failures observed. Actions incident 3q1yb5m7ltvb was reported in dispatch; no workflows rerun. LIGHT phase only, existing dependencies, no live backend or production testing. Independent nonauthor review remains pending.
|
|
Independent exact-head verdict for TALE-935 / TALE-186 / TALE-359 Reviewed Verdict: the #3642 save-visibility fix passes; the full brief cannot be marked clean because stale-write protection is still absent at this head. No new blocking defect found in the four-file change. The stale-write gap predates this PR and is separately addressed by open PR #4192 (issue #3933); this is not a claim that #4405 introduced it. Observed:
Local verification using existing dependencies:
CI: pending, stalled incident Posting fallback: |
59a0877 to
3381e04
Compare
3381e04 to
7c05469
Compare
7c05469 to
fdec8ed
Compare
A successful skill save cleared the local form after awaiting query invalidation. When normalized saved data stayed unchanged, or detail refreshed before the library, no effect reseeded it and the editor went blank.
Render saved values directly whenever there is no local draft. Successful saves now keep Description, Labels, Visibility and Instructions visible and leave Save clean, while refusals preserve the draft.
Validation:
/opt/node/bin/node.git merge-treechecked 75 open heads against the change and main. No new conflicts or duplicate anchors; 31 heads already conflict with main.LIGHT phase only; existing dependencies. HTTP fixtures use an in-memory door, not the file store or a live backend. Actions was reported stalled under incident 3q1yb5m7ltvb; checks will be watched without rerunning workflows. Independent nonauthor review remains required.
Closes #3642
Current-main rebase
Replayed the previously accepted source
3381e04bcd2086edafdb621ff71588c135fb2789onto maind1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.Maintenance replay: preserves the accepted feature payload on main fd277c4, including merged #4649, #4650 and #4655. Retains the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), pending native merge on main. The #4282 task-register union, where applicable, retains the accepted feature row and current-main rows. Existing behavioral evidence remains recorded above; no fresh full-feature/full-workspace or hosted-green claim. All seven native required contexts and full merge-group validation remain mandatory.