Repository navigation
fix(platform): expose all contact source filters - #4406
Conversation
|
TALE-293 / TALE-359 dispatch report — ready for independent nonauthor review. Implemented at Verification: 36 targeted UI tests and 80 targeted backend tests passed; final wire rerun passed all 10 tests. Scoped type-aware lint, eight-file TypeScript checks, formatting and manual-layer checks passed. The regression fails against the original four-option component. Real Chromium visual-aspect-analyzer baseline and final both scored 100. The coverage anchor is unique across 75 open PR heads; git merge-tree found no introduced register conflicts (26 conflicts already occur against unchanged main). CI snapshot: 21 checks queued and seven conditional candidate-source checks skipped. GitHub Status confirms an active Actions major outage (investigating, updated 21:22:39 UTC); no reruns requested. Local Opengrep was skipped because the pinned binary is not cached; its CI check is pending. Tests and browser review use synthetic data, with no production writes. Independent review and green CI remain open; no merge performed. Direct task reporting is unavailable: workspace_status returned unavailable/not_granted. This PR comment is the requested fallback for TALE-293 and the TALE-359 dispatch report. Patch, report, screenshots and verification logs are in the task's delivery box. |
|
Exact-head review verdict for 93e02b6: APPROVE. Reviewed the shared 25-value Validation: route tests were inspected and the table/route Vitest invocation was attempted with one worker, but this checkout's existing Storybook preset resolution ( |
93e02b6 to
4360fbf
Compare
dd25ed6 to
1561c82
Compare
1561c82 to
212d669
Compare
Contacts previously offered only four Source filters, leaving connector and webhook contacts impossible to narrow from the directory. Render all 25 supported sources from one shared catalog, reuse the existing source labels, and preserve the current URL/request filtering. The backend re-exports the catalog and type for existing consumers.
Verification:
Existing EN/DE/FR labels cover every source; vendor names retain their established spelling. Independent review and CI remain required. No CI reruns will be requested during the reported Actions incident.
Closes #3865
Current-main rebase
Replayed the previously accepted source
dd25ed62fca24ce4a66b8030f866fba4e1b6bb84onto maind1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.Maintenance replay: preserves the accepted feature payload on main fd277c4, including merged #4649, #4650 and #4655. Retains the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), pending native merge on main. The #4282 task-register union, where applicable, retains the accepted feature row and current-main rows. Existing behavioral evidence remains recorded above; no fresh full-feature/full-workspace or hosted-green claim. All seven native required contexts and full merge-group validation remain mandatory.