Skip to content

fix(platform): expose all contact source filters - #4406

Merged
yannickmonney merged 1 commit into
mainfrom
fix/contacts-source-filter
Oct 9, 2026
Merged

yannickmonney merged 1 commit into
mainfrom
fix/contacts-source-filter

Conversation

@yannickmonney

@yannickmonney yannickmonney commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Contacts previously offered only four Source filters, leaving connector and webhook contacts impossible to narrow from the directory. Render all 25 supported sources from one shared catalog, reuse the existing source labels, and preserve the current URL/request filtering. The backend re-exports the catalog and type for existing consumers.

Verification:

  • Targeted Contacts UI tests: 36 passed across five files; final wire regression rerun: 10 passed. Covers Shopify, Webhook, the original four sources, URL serialization/restoration, request values and matching rows.
  • Targeted contacts routes/service and conversation shim tests: 80 passed, including API acceptance of every supported source.
  • Scoped type-aware oxlint, scoped TypeScript checks (eight files), oxfmt, manual-layer and conflict-marker checks passed.
  • New catalog assertion fails against the original component (4 options instead of 25).
  • Real Chromium component harness: visual-aspect-analyzer baseline and final score 100, no defects. Harness uses synthetic reads; no production writes.
  • Coverage anchor checked against 75 open PR heads with git merge-tree: unique, no introduced register conflicts; 26 register conflicts already exist between main and those heads.

Existing EN/DE/FR labels cover every source; vendor names retain their established spelling. Independent review and CI remain required. No CI reruns will be requested during the reported Actions incident.

Closes #3865

Current-main rebase

Replayed the previously accepted source dd25ed62fca24ce4a66b8030f866fba4e1b6bb84 onto main d1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.

Maintenance replay: preserves the accepted feature payload on main fd277c4, including merged #4649, #4650 and #4655. Retains the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), pending native merge on main. The #4282 task-register union, where applicable, retains the accepted feature row and current-main rows. Existing behavioral evidence remains recorded above; no fresh full-feature/full-workspace or hosted-green claim. All seven native required contexts and full merge-group validation remain mandatory.

@yannickmonney

yannickmonney commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor Author

TALE-293 / TALE-359 dispatch report — ready for independent nonauthor review.

Implemented at 93e02b6eb: Contacts now exposes all 25 supported Source options from a shared catalog, using existing labels and URL/request handling. Shopify, Webhook and the original four choices are covered through selection, URL restoration, HTTP request and rendered rows. Closes #3865.

Verification: 36 targeted UI tests and 80 targeted backend tests passed; final wire rerun passed all 10 tests. Scoped type-aware lint, eight-file TypeScript checks, formatting and manual-layer checks passed. The regression fails against the original four-option component. Real Chromium visual-aspect-analyzer baseline and final both scored 100. The coverage anchor is unique across 75 open PR heads; git merge-tree found no introduced register conflicts (26 conflicts already occur against unchanged main).

CI snapshot: 21 checks queued and seven conditional candidate-source checks skipped. GitHub Status confirms an active Actions major outage (investigating, updated 21:22:39 UTC); no reruns requested. Local Opengrep was skipped because the pinned binary is not cached; its CI check is pending. Tests and browser review use synthetic data, with no production writes. Independent review and green CI remain open; no merge performed.

Direct task reporting is unavailable: workspace_status returned unavailable/not_granted. This PR comment is the requested fallback for TALE-293 and the TALE-359 dispatch report. Patch, report, screenshots and verification logs are in the task's delivery box.

@yannickmonney

Copy link
Copy Markdown
Contributor Author

Exact-head review verdict for 93e02b6: APPROVE.

Reviewed the shared 25-value CONTACT_SOURCES catalog, backend enum validation and UI facets. Shopify, Webhook, and the four existing source options are covered by the wire tests, including navigation/search URL round-trip and restored list requests. EN/DE/FR source labels exist, and the list API's accepted values remain the same. git merge-tree origin/main 93e02b6e is clean (register anchor does not collide).

Validation: route tests were inspected and the table/route Vitest invocation was attempted with one worker, but this checkout's existing Storybook preset resolution (Cannot find package 'file:') prevents execution. CI is stalled under incident 3q1yb5m7ltvb and was not rerun; status remains pending.

@yannickmonney
yannickmonney added this pull request to the merge queue Oct 9, 2026
@yannickmonney
yannickmonney removed this pull request from the merge queue due to the queue being cleared Oct 9, 2026
@yannickmonney
yannickmonney force-pushed the fix/contacts-source-filter branch from 93e02b6 to 4360fbf Compare October 9, 2026 04:30
@yannickmonney
yannickmonney force-pushed the fix/contacts-source-filter branch 2 times, most recently from dd25ed6 to 1561c82 Compare October 9, 2026 14:10
@yannickmonney
yannickmonney force-pushed the fix/contacts-source-filter branch from 1561c82 to 212d669 Compare October 9, 2026 15:23
@yannickmonney
yannickmonney added this pull request to the merge queue Oct 9, 2026
@yannickmonney
yannickmonney added this pull request to the merge queue Oct 9, 2026
@yannickmonney
yannickmonney merged commit efcf391 into main Oct 9, 2026
64 checks passed
@yannickmonney
yannickmonney deleted the fix/contacts-source-filter branch October 9, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(platform): Contacts Source filter omits connector and webhook sources

1 participant