Skip to content

fix(platform): preserve credential edits after remote deletion - #4409

Open
yannickmonney wants to merge 1 commit into
mainfrom
fix/credential-edit-delete
Open

yannickmonney wants to merge 1 commit into
mainfrom
fix/credential-edit-delete

Conversation

@yannickmonney

@yannickmonney yannickmonney commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Keep the Edit credential dialog mounted at table scope so a live refetch cannot discard its draft when the edited credential is deleted elsewhere. Show a localized warning and disable Save while retaining the draft.

Verified: scoped oxlint, oxfmt, TypeScript check. Focused Vitest could not resolve the repository @ alias in this environment.

Closes #4082

Current-main rebase

Replayed the previously accepted source d39bc6e4e9a4ee6e98a89c67111c6a8c06c59d4f onto main d1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.

Maintenance replay: preserves the accepted feature payload on main fd277c4, including merged #4649, #4650 and #4655. Retains the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), pending native merge on main. The #4282 task-register union, where applicable, retains the accepted feature row and current-main rows. Existing behavioral evidence remains recorded above; no fresh full-feature/full-workspace or hosted-green claim. All seven native required contexts and full merge-group validation remain mandatory.

@yannickmonney

Copy link
Copy Markdown
Contributor Author

Exact-head independent review: PASS for 33baa59b2b4545e263fb8c66c6ff9febe47c3b53.

The table-level owner keeps Edit mounted across credential refetches, derives deletion by id, retains the typed draft, shows the localized warning, and disables Save. The same CredentialTable is used by connector and AI-provider settings. Legitimate close clears editing and unmounts the dialog; the shared dialog focus restoration handles the menu opener. EN/DE (du)/FR (tu) copy is present and semantically aligned. Existing focused tests pass (2/2) with one worker; the initial font-asset denial was resolved with the review-only server.fs.allow config. CI remains pending; no rerun.

Review note: the automated test file covers draft retention and reseeding but does not directly cover deletion warning/disabled Save or cross-session refetch; those remain manual coverage as recorded by SET-F23.

@yannickmonney
yannickmonney force-pushed the fix/credential-edit-delete branch from 33baa59 to 652b91f Compare October 9, 2026 02:14
@yannickmonney
yannickmonney force-pushed the fix/credential-edit-delete branch 6 times, most recently from d39bc6e to bec2a4e Compare October 9, 2026 14:10
@yannickmonney
yannickmonney force-pushed the fix/credential-edit-delete branch from bec2a4e to 43a1929 Compare October 9, 2026 15:24
@yannickmonney
yannickmonney added this pull request to the merge queue Oct 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(platform): an Edit credential dialog vanishes with its draft when another admin deletes the credential

1 participant