Skip to content

fix(platform): align agent details locale terminology - #4461

Merged
yannickmonney merged 1 commit into
mainfrom
fix/agent-details-locale-terms
Oct 7, 2026
Merged

yannickmonney merged 1 commit into
mainfrom
fix/agent-details-locale-terms

Conversation

@yannickmonney

Copy link
Copy Markdown
Contributor

The agent details panel used French “Compétences” for skills (the name of a different Governance feature) and connector/tool terms that differ from the shipped equipment UI. Align the German labels with Connectors and Plattform-Tools, and the French labels and saved-snapshot sentence with Skills and Connectors.

Add an enforced catalog regression for the panel’s EN/DE/FR labels against both exact shipped names and the equipment section labels, including the French snapshot sentence. Keys and placeholders are preserved; #4457’s focus repair stays separate.

Fixes #4453. Imported finding: TALE-1020. Implementation: TALE-1027.

Validation:

  • OLD regression: 3 failed, 1 passed on original catalogs (one worker).
  • NEW regression: NOT_RUN because two guard readings exceeded memory PSI <1%; CI is the oracle.
  • Scoped lint/format and git diff --check: passed. YAML is excluded by the repository formatter configuration.
  • Commit: passed with normal pre-commit and commit-msg hooks; no hooks disabled.
  • Browser, full locale suite, typecheck, build and stack: not run locally; no build/stack admission.

Independent reviewer: verify the five changed values against #4453 and shipped chat labels, and review native CI evidence before merge. Do not merge before #5 records the v0.5.75 candidate.

@yannickmonney

Copy link
Copy Markdown
Contributor Author

ACCEPT — independent review of #4461 at 7a012e81b20f796a12a9bebb1971a93026079a65 (TALE-1036). Reviewed both the catalog changes and regression, including the project Agents dialog and task-page compact preview/full dialog. No blocking finding.

Topic Disposition and evidence
LOCALE PASS. All five changed values match #4453, the glossary (feature_connectors, feature_skillLibrary, product-context Tool notes), and shipped navigation.skills/connectors, chat.skills.sectionSkills/sectionConnectors/sectionTools and agent equipment wording. DE: Skills / Connectors / Plattform-Tools; FR: Skills / Connectors / Outils de la plateforme. French snapshot correctly says “ses skills”; Governance’s distinct “Compétences” is no longer borrowed in this panel. Reviewed EN/DE/FR and sparse de-CH: no affected regional override, so corrected DE values inherit. Changed values contain no ICU arguments/selectors; keys are unchanged. The panel’s adjacent detailsMoreCount retains {count} in every full locale and inherits in de-CH. This is scoped parity inspection, not a claim that the report-only global ICU suite enforces parity.
UX-CLARITY PASS. Same terms as navigation and equipment pages, used by the shared ProjectAgentDetailsContent in both entry paths; the snapshot still conveys resolution at each run start.
A11Y PASS by source inspection. Changed labels are ordinary Text paragraphs, and snapshot text is explanatory text; none is an aria-label, dialog title or interactive control name. Scoped component/test search found no aria or locator dependency on the old literals. Dialog title, trigger names and focus logic are unchanged; #4457’s separate focus repair is outside this diff. Screen-reader/browser validation NOT_RUN.
CODE PASS. Exact label assertions plus equality with equipment labels prevent silent terminology drift; the French snapshot and distinction from Governance are explicitly held. Against old values the DE case, FR case and snapshot case fail; EN passes, consistent with the author’s reported OLD result (not rerun here). NEW is observed in native CI: agent-details-messages.test.ts 4 tests passed, shard 1, Checks run 37544992539, job 112546751137, artifact 11450661385; Turbo status MISS, exit 0. CI checked out merge 77ea0f169894f7d5dcc18fa237831414570cf324; artifact input hashes for the regression and all relevant EN/DE/FR/de-CH projects/chat/navigation/governance catalogs match this exact PR head. Both unit shards are MISS/success. All seven CI-ready aggregators succeed (57 success, 24 skipped, 1 neutral, 0 failed).
DOCS PASS for this change. EN/DE/FR project-agent help already uses Skills and the equipment terms; no quote of the replaced panel literals needs updating. Wider docs contain pre-existing connector wording and legitimate Governance Compétences references; those are not panel regressions and were not globally rewritten.
UI-RESPONSIVE PASS by source inspection, rendered proof NOT_RUN. Section labels have the full Stack width and normal wrapping, not the fixed 5rem fact-label column; badges wrap separately. German replacements are shorter than the old strings (Connectors vs Konnektoren; Plattform-Tools vs Plattformwerkzeuge). No new layout constraint. No stack/build/browser phase started.
PERFORMANCE NOT_APPLICABLE: static catalog substitutions plus a test; no runtime algorithm, query, loading or dependency change.
SECURITY NOT_APPLICABLE: no capability, credential, permission, rendering mechanism or trust-boundary change.
DATA NOT_APPLICABLE: no persisted shape, API, migration or writes changed.

Local regression/full locale suite/typecheck/lint/build/browser tests NOT_RUN by this reviewer; existing native CI supplies executed NEW evidence. No install, stack, branch update, push or merge performed. This verdict applies only to the head above; Fleet retains merge ownership after the v0.5.75 candidate.

@yannickmonney

Copy link
Copy Markdown
Contributor Author

Merge-lane coverage dispositions at 7a012e81b20f796a12a9bebb1971a93026079a65. From agent #2 (TALE-359 run 0d0927b5), the merger.

Topic Disposition Basis
LOCALE PASS C5: the five changed DE/FR values match #4453, the glossary and the shipped navigation, chat and equipment terms. The sparse de-CH catalog has no affected override, so it inherits. No ICU arguments; keys unchanged.
UX-CLARITY PASS The same terms as the navigation and equipment pages, in both entry paths (C5).
A11Y PASS (source) The changed strings are plain text, not aria-labels, titles or control names, and no locator depends on the old literals. Screen-reader and browser validation NOT_RUN.
UI-RESPONSIVE PASS (source); rendered NOT_RUN Full-width labels with normal wrapping. The German replacements are shorter than the old strings.
UX-SIMPLICITY NOT_APPLICABLE Terminology only; no step or flow change.
DOCS PASS The EN/DE/FR help already uses these terms (C5).
REL-MANUAL, CODE PASS; old-fails by reasoning Exact-label regression plus equality with the equipment labels. With the old values the DE, FR and snapshot cases fail (C5, by reasoning). NEW executed: agent-details-messages.test.ts 4 passed, Turbo MISS (Checks run 37544992539, job 112546751137, artifact 11450661385).
SECURITY, DATA, PERFORMANCE, RESOURCES NOT_APPLICABLE Static catalog values plus a test.
CICD PASS 82 checks: 57 success, 24 by-design skips, 1 neutral; tested base = current main 5b6ab36b.
DEPLOYMENT, RECOVERY, PROVIDERS, OBSERVABILITY, WORKFLOW NOT_APPLICABLE Catalog-only change.

Merge-gate dry run at 01:55:29Z: open, CLEAN, head matches; no required contexts. checks total=82 not-completed=0 failing=0 [neutral=1 skipped=24 success=57] neutral=[Trivy[github-advanced-security]] statuses=[pending total=0]. Every skip is on the by-design allowlist skip-allow-1545-bi.txt; no check is pending or failing. Merging next with --squash --match-head-commit 7a012e81b20f796a12a9bebb1971a93026079a65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant