Repository navigation
fix(platform): unify agent runtime terminology across locales - #4480
Conversation
|
REQUEST CHANGES — reviewed head
|
|
ACCEPT — delta-only close-out at f5919a8. The complete delta from 686c5da changes only docs/de/platform/index.md:103. “Mit einer passenden Agent-Laufzeit, einem passenden Modell und passender Ausstattung” now has correct dative agreement for all three nouns and closes my German agreement finding in comment 6035242813. No other changes appear in the delta. All seven CI ready aggregators report completed/success at this head; Browser job 112738463177 also reports completed/success. This is a CI-status observation, not a claim of uncached execution. No tests, installs, builds, reruns or cancellations were performed. |
|
Merge-lane coverage dispositions at
Merge-gate dry run at 10:57:41Z: open, CLEAN, head matches; no required contexts. checks total=83 not-completed=0 failing=0 [neutral=1 skipped=19 success=63] neutral=[Trivy[github-advanced-security]] statuses=[pending total=0]. Every skip is on the by-design allowlist |
Runtime selection was called Agent type, Agent runtime and Harness across the same workflows. Project agents, Governance, automation nodes, provider status and analytics now use Agent runtime (EN), Agent-Laufzeit (DE) and Environnement d'agent (FR). The matching documentation, marketing links and glossary use the same terms. Keys, ICU arguments, API fields, stored values, code examples and URLs stay unchanged. Renamed documentation headings retain their published anchors.
Fixes #4441. Implements TALE-1095.
Validation: platform i18n messages suite 33 passed (including six cross-screen terminology regressions);
bun run lint:linkspassed (449 documentation pages, 9,139 tracked files). Each check had its own two passing host guard readings and one worker/process. Existing dependencies only; Node /opt/node/bin/node.NOT_RUN locally: packages/ui usage suite, entry-budget build proof, full docs structural suite, affected component tests, lint/typecheck, browser/visual review and screenshots. These phases were not admitted; build/install/stack are prohibited. CI is the remaining oracle. No reruns or merge. Project-secrets access wording from #4469 was re-read and preserved because it contains no old runtime term. de-CH has no conflicting overrides and inherits German.
Base: e011cc8. Independent review requested through the task handoff; this implementation does not constitute independent acceptance.
Before/after coverage (includes all issue-listed keys, even when already canonical):
en
de
fr
Glossary
The glossary preserves the existing report-only check modes. The new platform regression rejects the old displayed synonyms in EN/DE/FR without rejecting harness identifiers.
CI checkpoint
Read once at 2026-10-07T08:17:22.066424+00:00. All results remain pending; no success is claimed and no rerun requested.
Next owner: Fleet coordination / assigned independent reviewer. Next check: 2026-10-07 08:30 UTC. Review packages/ui usage, platform checks, entry budget and docs/browser outcomes before acceptance. Do not merge from this handoff.
Repair scope review — dispatch eee95e47
The complete PR now touches 109 files in these groups:
No unrelated file was found in the scope review.
projectSecrets.agentAccessBodyremains unchanged because #4469 already removed the conflicting term.Repair: UI failures at d88b548 pinned the deliberately replaced wording. Updated the provider subscription badge sentence and all six EN/DE/FR analytics load/refresh error sentences. Other platform UI-test assertions on the old terms were searched; none remain (a historical comment still quotes the old copy).
Repair validation: both changed test files passed, 21 tests, with
/opt/node/bin/node, existing dependencies, one worker and no file parallelism, after two passing guard readings. No install, build, stack, CI rerun or merge.Independent-review repair — c84d4010
Resolved C3 comment 6035242813: the German platform index now reads “Agenten mit einer passenden Agent-Laufzeit, einem passenden Modell und passender Ausstattung für Projektaufgaben einrichten.” A bounded sweep of the German files changed by this PR found no other instance of the defective agreement. One sentence changed; keys, API fields, stored values and links remain untouched. Checkout: /agent/workspace/tale. Repair head: f5919a8.
Guarded docs link check passed: 449 pages and 9,139 tracked files. Normal commit hooks passed; same branch/PR, no force push. The unrelated home-panel.browser.test.tsx failure was left untouched.