You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(proxy): keep deployment control off public routes - #4563
Public /api/control requests currently reach the backend through both the explicit proxy route and the general API fallback. Refuse the root and descendant paths at the proxy. The CLI continues using its authenticated docker exec channel to the selected backend container.
Adds regression coverage to the existing Compose parity and real container smoke suites. Local verification: 123 tests / 2,400 assertions passed; a 32-case Caddy 2.11.4 loopback canary confirmed the previous routing and the corrected refusal, including encoded paths and subpath deployments. Formatting, scoped lint, shell syntax and the manual-test register pass. Independent source review passed; hosted container and required CI checks remain pending.
This reviewed source is now included in #4565 at 7a526754c1c453e547e6ebb0234bf38c730009e3, together with the other release safety repairs. Independent composition review verified the source blobs are unchanged and the shared coverage register retains every addition.
I am marking this PR as draft to prevent a separate merge and cancelling only its superseded CI runs. The replacement must pass its own seven complete workflows; this PR's checks are retained as historical evidence. This change has not shipped. This PR will be closed as superseded after #4565 merges.
Implemented in #4565, merged as 0ee5fd9656dc12f08976155d956ee76fe39f4ea3. The proxy change and its integration/Compose tests are included; the coverage row now lives in the per-suite settings register. Closing this superseded draft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public
/api/controlrequests currently reach the backend through both the explicit proxy route and the general API fallback. Refuse the root and descendant paths at the proxy. The CLI continues using its authenticateddocker execchannel to the selected backend container.Adds regression coverage to the existing Compose parity and real container smoke suites. Local verification: 123 tests / 2,400 assertions passed; a 32-case Caddy 2.11.4 loopback canary confirmed the previous routing and the corrected refusal, including encoded paths and subpath deployments. Formatting, scoped lint, shell syntax and the manual-test register pass. Independent source review passed; hosted container and required CI checks remain pending.