Skip to content

fix(sandbox): pin cache helpers to local runtime image IDs - #4609

Merged
yannickmonney merged 2 commits into
mainfrom
fix/sandbox-local-runtime-helper-id
Oct 9, 2026
Merged

yannickmonney merged 2 commits into
mainfrom
fix/sandbox-local-runtime-helper-id

Conversation

@yannickmonney

@yannickmonney yannickmonney commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Cache permission setup switched to the already-local runtime image in #4551. A configured mutable tag could then select a different root helper if its local mapping changed. Resolve and validate the local sha256 image ID first and run that exact image with --pull=never, --network none and /bin/chmod as the entrypoint. Missing or invalid identities refuse execution; missing-image warmup signaling and fresh-volume cleanup remain intact.

The operator README and existing automation row describe the same contract. New main incarnation tests and its registry dependency updater remain intact. The branch is rebased onto current main; the retention test’s fake Docker now answers the same local-image inspection prerequisite as the other volume fixtures.

Validation:

  • Pinned Bun 1.4.2: 44 focused tests pass, 147 assertions, including current main’s package-cache retention tests. All seven new identity regression cases fail against the pre-fix implementation.
  • Sandbox typecheck and type-aware lint; formatting, conflict, manual and documentation-link guards pass.
  • Ordinary pre-commit and commitlint hooks pass. The repository SAST scan reports zero findings.
  • The initial full bun run check used host Bun 1.3.10 and stopped at the unchanged E2E interrupted-body fixture. That case passes with pinned Bun 1.4.2; A later broad sandbox run encountered timeouts and did not complete; complete repository validation remains for native CI.

No real Docker daemon or provider was exercised; the tests drive bounded subprocess fixtures and composed session behavior.

@yannickmonney
yannickmonney force-pushed the fix/sandbox-local-runtime-helper-id branch 2 times, most recently from b2941cf to 26c6d49 Compare October 9, 2026 04:29
@yannickmonney
yannickmonney force-pushed the fix/sandbox-local-runtime-helper-id branch from 26c6d49 to cb2972a Compare October 9, 2026 04:46
@yannickmonney
yannickmonney added this pull request to the merge queue Oct 9, 2026
@yannickmonney
yannickmonney merged commit 96b8f16 into main Oct 9, 2026
64 checks passed
@yannickmonney
yannickmonney deleted the fix/sandbox-local-runtime-helper-id branch October 9, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant