Repository navigation
fix(platform): repair the tests and rule ids the agent worker merge broke - #4615
Merged
Merged
Conversation
Imported at the top of the board ops test, agent-runs.ts was sorted ahead of the service and bound it to the real project service, so the mocked project lookup never ran and all three cases failed. The test loads the two predicates where it compares them.
The sandbox spec stated SBX-R17 twice: the rule that a workspace outlives its sandbox landed first, and the agent worker rules took R17 to R20 in a branch beside it. The worker rules are SBX-R18 to SBX-R21 now, in the spec, the tasks spec and the tests that hold them.
A start for a busy agent waits for a worker now, so no task writer records an agent_busy refusal any more; the walk's sanity anchor is the circuit breaker alone. The label stays for the rows older runs left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's server unit suite and the domain-spec guard are red since #4603 (agent workers), which was merged without CI. Every merge group fails Unit until this lands.
SBX-R17 is stated twice. fix(sandbox): keep agent workspaces through lost sandboxes #4560 took SBX-R17 ('a workspace outlives its sandbox') first, so the agent worker rules move to SBX-R18–R21 in the sandbox spec, the tasks spec and the tests that hold them../agent-runs.tsimport, which import sorting puts ahead of the service, bound the service to the real project service. The predicates are now loaded where the test compares them.agent_busyrefusal that no writer records any more (a busy agent's run waits for a worker now). Thetask_circuit_breakeranchor stays; the label stays for older rows.Verified on main + this change: the spec guard, sandbox and tasks domain tests and ops indicators (29 files, 564 tests), and display.test.ts (4/4).