Repository navigation
test(sandbox): read the staged manifest in tests without unsafe casts - #4636
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime daemon's type-aware lint (
bunx oxlint --type-aware, thelintjob) failed on main with threeno-unsafe-type-assertionerrors in the staged-manifest tests from #4631: a dynamicimport()cast to the module type, and twoJSON.parsecasts. These now go through type guards. Behaviour is unchanged; 39 tests pass, and the daemon lint and type-check are clean.The unused exports that knip reports on main (two of them from the sandbox wave) are already removed by the open #4625, so this PR does not touch them.