Repository navigation
test(sandbox): synchronize background mirror pull assertions - #4663
Merged
Merged
Conversation
yannickmonney
enabled auto-merge
October 9, 2026 17:25
yannickmonney
force-pushed
the
ci/sandbox-mirror-pull-readiness
branch
2 times, most recently
from
October 9, 2026 21:06
1a09f79 to
dc99644
Compare
yannickmonney
force-pushed
the
ci/sandbox-mirror-pull-readiness
branch
from
October 9, 2026 21:09
dc99644 to
4aa130c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace unit job can report two mirror-image pulls although production correctly deduplicates pulls that are still running. The fake pull finishes immediately; a late missing-image result can legitimately start a new pull after the first completes.
Keep the fake pull blocked until all three mirror attempts and builder create return. Wait for the marker’s exact contents, verify one in-flight pull, retain all three
--pull neverattempts, and require the eventual completed pull. Production behavior is unchanged.Current main already contains the shared observation-suite inventory repair, so this rebased PR now changes only
services/sandbox/src/buildkit-lifecycle.test.ts.Base
maincommit71b5ec6e05e86ccf0f4b40e58ff5fbfbee5980; head4aa130cb355da8f5bf451f34e51e736dea369449; exact one-path diff. The accepted source proof covered 1,468 sandbox tests on Linux, 32 workflow-policy tests, sandbox types, scoped type-aware lint/format and strict scoped SAST. Full native source and merge-group validation remain required; no whole-workspace, live deployment or PostgreSQL proof is claimed.