Repository navigation
fix: restore main's spec heading and CLI input guards - #4666
Closed
yannickmonney wants to merge 2 commits into
Closed
yannickmonney wants to merge 2 commits into
yannickmonney wants to merge 2 commits into
Conversation
yannickmonney
enabled auto-merge
October 9, 2026 18:37
yannickmonney
added a commit
that referenced
this pull request
Oct 9, 2026
The same three changes as #4666 — AUDIT-R7's heading, the audit request actor in the CLI's turbo inputs, and the observation suite in the phase-selector test — so this branch's checks pass on today's main; whichever lands first, the other merges cleanly.
yannickmonney
added a commit
that referenced
this pull request
Oct 9, 2026
Main's AUDIT-R7 heading is longer than the spec guard allows, its CLI lint inputs miss audit_logs/request-actor.ts, and the CLI phase list misses observation.test.ts; every pull request's checks inherit the three. The same lines as #4666, so whichever lands first leaves the other a no-op.
yannickmonney
force-pushed
the
fix/audit-r7-heading
branch
from
October 9, 2026 20:54
7f5fc2b to
64c1f5a
Compare
yannickmonney
force-pushed
the
fix/audit-r7-heading
branch
from
October 9, 2026 21:04
64c1f5a to
37d8f7d
Compare
yannickmonney
enabled auto-merge
October 9, 2026 21:05
yannickmonney
force-pushed
the
fix/audit-r7-heading
branch
from
October 9, 2026 21:09
37d8f7d to
e31ceaf
Compare
The domain-specs guard holds a rule's heading to one plain sentence of at most 80 characters; AUDIT-R7's ran to 86 and failed the guard on main and in every pull request's merge check. The card's body is unchanged.
Two of main's CLI guards failed after recent merges: services/platform/backend/domains/audit_logs/request-actor.ts (from #4659) is imported by code the CLI's cached checks hash but was missing from their turbo inputs, and the observation command suite is a source/compiled suite the phase-selector test did not expect yet.
yannickmonney
force-pushed
the
fix/audit-r7-heading
branch
from
October 9, 2026 21:41
e31ceaf to
03ac1d4
Compare
Contributor
Author
|
Closing as no longer needed: main carries all three of these lines since #4621 landed (it included the same fix so its own checks could pass) — the AUDIT-R7 heading, |
auto-merge was automatically disabled
October 9, 2026 22:24
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Current main still has two independent guard failures after the recent merges:
A key-made entry names the key's maker, its subject the member it acts for(74 characters); the body, example and tests are unchanged.services/platform/backend/domains/audit_logs/request-actor.tsis imported by code the CLI's cached checks hash, but was missing fromtools/cli/turbo.jsoninputs.The observation command-suite inventory line is already present on current main and is intentionally not duplicated in this rebased diff.
Verified
14921c9b2759b4e05225a8b2f515a37a4f49e132; head03ac1d4b633457f787a08d68134d56b05888680a.services/platform/backend/domains/audit_logs/spec.mdandtools/cli/turbo.jsononly.All seven native required contexts and the complete merge-group gate remain mandatory.