Skip to content

fix: restore main's spec heading and CLI input guards - #4666

Closed
yannickmonney wants to merge 2 commits into
mainfrom
fix/audit-r7-heading
Closed

yannickmonney wants to merge 2 commits into
mainfrom
fix/audit-r7-heading

Conversation

@yannickmonney

@yannickmonney yannickmonney commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

What

Current main still has two independent guard failures after the recent merges:

  • Domain-spec guard — AUDIT-R7's heading exceeded the one-sentence limit. It is now A key-made entry names the key's maker, its subject the member it acts for (74 characters); the body, example and tests are unchanged.
  • CLI cached checks — services/platform/backend/domains/audit_logs/request-actor.ts is imported by code the CLI's cached checks hash, but was missing from tools/cli/turbo.json inputs.

The observation command-suite inventory line is already present on current main and is intentionally not duplicated in this rebased diff.

Verified

  • Base main commit 14921c9b2759b4e05225a8b2f515a37a4f49e132; head 03ac1d4b633457f787a08d68134d56b05888680a.
  • Exact current diff: services/platform/backend/domains/audit_logs/spec.md and tools/cli/turbo.json only.
  • Focused CI workflow tests: 16 passed, 0 failed, 424 assertions on the pre-existing repair; the current-main rebase is conflict-free.
  • Oxfmt and whitespace checks pass.

All seven native required contexts and the complete merge-group gate remain mandatory.

@yannickmonney yannickmonney changed the title fix(platform): keep the AUDIT-R7 heading to one short sentence fix: restore main's spec heading and CLI input guards Oct 9, 2026
yannickmonney added a commit that referenced this pull request Oct 9, 2026
The same three changes as #4666 — AUDIT-R7's heading, the audit request actor in the CLI's turbo inputs, and the observation suite in the phase-selector test — so this branch's checks pass on today's main; whichever lands first, the other merges cleanly.
yannickmonney added a commit that referenced this pull request Oct 9, 2026
Main's AUDIT-R7 heading is longer than the spec guard allows, its CLI lint inputs miss audit_logs/request-actor.ts, and the CLI phase list misses observation.test.ts; every pull request's checks inherit the three. The same lines as #4666, so whichever lands first leaves the other a no-op.
@yannickmonney
yannickmonney added this pull request to the merge queue Oct 9, 2026
@yannickmonney
yannickmonney removed this pull request from the merge queue due to a manual request Oct 9, 2026
@yannickmonney
yannickmonney added this pull request to the merge queue Oct 9, 2026
@yannickmonney
yannickmonney removed this pull request from the merge queue due to a manual request Oct 9, 2026
The domain-specs guard holds a rule's heading to one plain sentence of at most 80 characters; AUDIT-R7's ran to 86 and failed the guard on main and in every pull request's merge check. The card's body is unchanged.
Two of main's CLI guards failed after recent merges: services/platform/backend/domains/audit_logs/request-actor.ts (from #4659) is imported by code the CLI's cached checks hash but was missing from their turbo inputs, and the observation command suite is a source/compiled suite the phase-selector test did not expect yet.
@yannickmonney

Copy link
Copy Markdown
Contributor Author

Closing as no longer needed: main carries all three of these lines since #4621 landed (it included the same fix so its own checks could pass) — the AUDIT-R7 heading, audit_logs/request-actor.ts among the CLI lint inputs, and observation.test.ts in the CLI phase list. git diff origin/main fix/audit-r7-heading on these files is empty.

auto-merge was automatically disabled October 9, 2026 22:24

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant