Skip to content

chore: Refresh non-PyModbus dependency lockset and stabilize docs toolchain compatibility - #19

Merged
gavinying merged 2 commits into
mainfrom
copilot/review-update-dependencies
Oct 28, 2026
Merged

gavinying merged 2 commits into
mainfrom
copilot/review-update-dependencies

Conversation

Copilot AI commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

This PR updates locked development/documentation/transitive dependencies while preserving the project’s Python support range (>=3.10,<4.0) and keeping PyModbus unchanged. It also resolves doc-build breakage introduced by newer transitive docs packages by adding explicit compatibility bounds.

  • Scope and invariants

    • Kept pymodbus untouched (~3.16.1).
    • Kept Python constraint unchanged: >=3.10,<4.0.
  • Dependency refresh

    • Regenerated poetry.lock with Poetry 1.8.3-compatible metadata.
    • Refreshed in-range dev/docs/transitive packages (no application code changes).
    • Re-exported generated dependency metadata (requirements.txt) to stay consistent with lock state.
  • Docs toolchain compatibility guards

    • Added explicit docs constraints to prevent incompatible transitive upgrades with current mkdocstrings line:
      • mkdocs-autorefs = ">=1.2,<1.4"
      • markdown = ">=3.7,<3.8"
      • pymdown-extensions = ">=10.11,<11"
[tool.poetry.group.docs.dependencies]
mkdocs = "^1.6.0"
mkdocs-material = "^9.5.28"
mkdocstrings = {extras = ["python"], version = "^0.25.1"}
mkdocs-autorefs = ">=1.2,<1.4"
markdown = ">=3.7,<3.8"
pymdown-extensions = ">=10.11,<11"
  • Intentionally not changed
    • No PyModbus upgrade/migration.
    • No application behavior or runtime logic changes.

Co-authored-by: gavinying <10823762+gavinying@users.noreply.github.com>
Copilot AI changed the title [WIP] Review and update dependencies outside PyModbus Refresh non-PyModbus dependency lockset and stabilize docs toolchain compatibility Oct 28, 2026
Copilot AI requested a review from gavinying October 28, 2026 05:29
@gavinying gavinying changed the title Refresh non-PyModbus dependency lockset and stabilize docs toolchain compatibility chore: Refresh non-PyModbus dependency lockset and stabilize docs toolchain compatibility Oct 28, 2026
@gavinying
gavinying requested a balanced review from Copilot October 28, 2026 06:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The dependency and lock pin refresh requires CI validation of compatibility bounds and Python 3.10–3.14 resolution that static checks alone cannot confirm.

No open issues 🎉

What changed in this PR

This PR refreshes the locked development, documentation, and transitive dependencies while deliberately preserving the project's public contract: pymodbus stays at ~3.16.1 and the Python support range stays >=3.10,<4.0. The core of the human-authored change is three explicit docs-group version bounds in pyproject.toml that cap transitive upgrades (mkdocs-autorefs, markdown, pymdown-extensions) to versions compatible with the current mkdocstrings 0.25 line, preventing doc-build breakage from newer releases. The poetry.lock (still @generated by Poetry 1.8.3) and requirements.txt export were regenerated to match.

I verified the constraints are internally consistent: poetry.lock resolves markdown 3.7, mkdocs-autorefs 1.3.1, and pymdown-extensions 10.21.3, all within the new bounds; mkdocs-material 9.7.7 (^9.5.28) and mkdocstrings-python 1.10.9 impose no conflicting requirements; and requirements.txt correctly contains only the unchanged main dependency (pymodbus==3.16.1). No application behavior changes are present, consistent with the PR's stated intent and issue #17.

Changes:

  • Added explicit docs-group upper/lower bounds in pyproject.toml to keep transitive docs tooling compatible with mkdocstrings 0.25.
  • Regenerated poetry.lock (in-range dev/docs/transitive refresh) and re-exported requirements.txt, keeping pymodbus and the Python range unchanged.
File Description
pyproject.toml Adds mkdocs-autorefs, markdown, and pymdown-extensions compatibility bounds for the docs group; all consistent with the resolved lock versions.

No objective issues were found in the reviewed change, so I have not stored any review comments.

Review effort: Balanced

@gavinying
gavinying marked this pull request as ready for review October 28, 2026 06:31
@gavinying
gavinying merged commit 58f5e21 into main Oct 28, 2026
8 of 12 checks passed
@gavinying
gavinying deleted the copilot/review-update-dependencies branch October 28, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deps] Review and update dependencies outside PyModbus

3 participants