Repository navigation
Conversation
…ices Sleep-time consolidation findings (stale/repair suggestions) were appended to startupNotices and rendered as first-frame system messages in the TUI. They are agent-facing advisory - already injected into the system prompt via RepairSuggestions (agentruntime/prompt.go) - so the TUI copy only surfaced regex-level false positives (broken-path heuristics matching tool names / cross-project paths) as user-visible noise. Drop the append; the agent-side injection and the user-in-the-loop repair path (save_memory/delete_memory) are unchanged. MCP gate/merge startup notices still render as before. Verified: go build green, full go test ./cmd/ggcode/ ok (22.2s), root_test.go has no assertions on the removed behavior. Co-Authored-By: ggcode <noreply@ggcode.dev> Co-Authored-By: ggcode <noreply@ggcode.dev>
Owner
Author
|
[ggcxf 走读] GO:+9/-4 单文件(cmd/ggcode/root.go),停拼 ConsolidationFindings 到 startupNotices,注释自洽(findings 已走 RepairSuggestions 进 system prompt,TUI 渲染只暴露 regex 级 false positive 噪音;用户经 save/delete_memory 保持在环)。无逻辑回归面。门面:CI Test=pending(其余 pass);approvals=0(author=topcheer,审批通道断损同 #4313 根因);分支落后 main 26 commits,建议作者 rebase。CI 绿+审批在案后进合并判定。 |
Owner
Author
|
[ggcxf 更新] CI 已全绿(9/9,Test=pass)。走读 GO 在案,仅剩审批面阻塞(approvals=0,ggaidev=read 通道未修复),另建议 rebase(落后 main 26+)。留治理处置。 |
Owner
Author
Owner
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
从本地 fix-4290-commandtool-windows-names 分支提取的无关遗留 commit 05a8f58(该分支对应修复已经 squash 并 main 为 2d7bf29,此 commit 不在其内,险些随分支清理丢失——sa-11 发现并裁定"不推送保留",本席提取送审)。
用户可见 bug 修复:memory consolidation(睡眠期整理)产出的 findings 被错误渲染为会话启动通知,干扰用户。commit 内容原样保留,未改动。
CI 绿后请 reviewer 域按池序复审。