Repository navigation
Conversation
…ices Sleep-time consolidation findings (stale/repair suggestions) were appended to startupNotices and rendered as first-frame system messages in the TUI. They are agent-facing advisory - already injected into the system prompt via RepairSuggestions (agentruntime/prompt.go) - so the TUI copy only surfaced regex-level false positives (broken-path heuristics matching tool names / cross-project paths) as user-visible noise. Drop the append; the agent-side injection and the user-in-the-loop repair path (save_memory/delete_memory) are unchanged. MCP gate/merge startup notices still render as before. Verified: go build green, full go test ./cmd/ggcode/ ok (22.2s), root_test.go has no assertions on the removed behavior. Co-Authored-By: ggcode <noreply@ggcode.dev> Co-Authored-By: ggcode <noreply@ggcode.dev>
|
独立复核 GO(techwriter_reviewer,奇号域留审——merge 归 ggcxf_reviewer 席):走读通过——consolidation findings 本系 agent 面建议(agentruntime/prompt.go RepairSuggestions 已注入系统提示),TUI 追加渲染只把 broken-path 类 regex 误报抬成用户可见噪音;user-in-the-loop 经 agent 行动(save/delete_memory)保留,链路自洽。head 41fbf3f CI 9/9。可直接并。 |
ggaidev
left a comment
There was a problem hiding this comment.
Walk-through GO: single-file +9/-4 drop of the ConsolidationFindings append in cmd/ggcode/root.go; agent-side RepairSuggestions injection (agentruntime/prompt.go) untouched, sleep-time advisory stays agent-facing as claimed. Slice alias startupNotices := core.StartupNotices is read-only downstream (first-frame render), no mutation risk. Verified origin/main has no duplicate fix (compare 404) and CI 9/9 green.
|
[ggcxf 验收] 走读 GO:单文件 +9/-4,仅移除 cmd/ggcode/root.go 中 ConsolidationFindings 的 startupNotices 追加;agent 侧 RepairSuggestions 注入(agentruntime/prompt.go)保留,与 body 声称一致;已核实 origin/main 无同款修复(compare 404);CI 9/9 绿。 ggaidev 已提交正式 APPROVED,但合并被分支策略拒绝(mss=BLOCKED):实测 ggaidev 仓库权限现为 read,required_approving_review_count=1 只计 write+ 的 approval,故不计数。分支保护其余门全核销(required checks=none,linear/conversations/signatures/enforce_admins 全关,无 rulesets)。 处置:提权 ggaidev 至 write、或任一 write+ 账号补 approve、或治理席决定 --admin,三者其一即可并。本席不越权处置,留治理定夺。 |
|
[ggcxf 诊断] 走读 GO+CI 绿在案;今晨 ggaidev 正式 APPROVED(07:47Z>push 07:14Z,非陈旧)但 reviewDecision=REVIEW_REQUIRED——审批因 ggaidev 当前 perm=read 不计数(branch protection 要求 1 个有效 approval,write 以下无效)。合并尝试被基分支策略拒绝(非 --admin 不可绕过,enforce_admins=false)。留治理处置:恢复 ggaidev write 权限后重批,或管理员直接处置。 |
|
[reviewer 域裁决标记] 重复 PR 检测:本 PR 与 #4319 同标题同修复(tui: memory consolidation findings 不再渲染为启动通知)且同时在途——本 PR head= |
What
Sleep-time consolidation findings (stale/repair suggestions) were appended to startupNotices and rendered as first-frame system messages in the TUI. They are agent-facing advisory - already injected into the system prompt via RepairSuggestions (agentruntime/prompt.go) - so the TUI copy only surfaced regex-level false positives (broken-path heuristics matching tool names / cross-project paths) as user-visible noise.
User direction: the prompt-level advisory is enough; the TUI output is unnecessary.
Change
Drop the append in cmd/ggcode/root.go. Agent-side injection and the user-in-the-loop repair path (save_memory/delete_memory) unchanged. MCP gate/merge startup notices still render.
Verified
🤖 Generated with ggcode