Skip to content

chore(tui): remove 9 dead mode.* i18n keys across 10 language catalogs (r61 scan) - #4317

Open
topcheer wants to merge 1 commit into
mainfrom
chore/deadcode-r61
Open

topcheer wants to merge 1 commit into
mainfrom
chore/deadcode-r61

Conversation

@topcheer

Copy link
Copy Markdown
Owner

r61 死码清理。自 en/zh/ja/ko/es/fr/de/ru/pt/vi 十 catalog 删除 9 个死键(180 行纯删除,10 文件×18 行,commit a6310dd,main@d9a682f 基):
mode.approval.{ask,none,critical}、mode.tools.{rules,readonly,safe,open}、mode.agent.{waits,autocontinue}

判据(100% 闭环):唯一调用者 sidebarModeApprovalKey/sidebarModeToolsKey/sidebarModeAgentKey(view_sidebar.go)已随往轮 f10fff9(confirmed dead code 清理,同批删 permission import)删除——9 键系该清理直接孤儿连锁;全仓双形态(双/单引号)多类型(go/ts/js/svelte/vue/html/json/md/tmpl/yaml)精确 grep 零引用;双席验证(子代理 43.7MB 拼接大文件严格双验 + 作者席主树独立 grep 30 命中全 catalog 定义一致)。代开者抽验:3 键双形态全仓 grep 命中全部为 i18n_*.go 十 catalog 定义文件(零非 catalog 命中);已删调用者主树零残留。

验证:清理后 build/vet 双 0 + TestI18N ok + pre-commit build 过。mode.current/mode.persist_failed 活键保留。

池情报(作者席附注):本轮发现 217 i18n 孤儿 key 大池(panel.16-provider 系 ~150 + 主 switch 域 ~60,清单 /tmp/dc61_confirmed.txt;update.pm_hint.* 4 键系拼接活引用假阳性已排除)——建议后续按 provider 分批(每轮 1-2 个,超 5 处纪律);TestI18NCompleteness 是软检查(Logf 不 Fail),池清理需 grep 双验。

(代开声明:作者席 gh pr create 被门禁拦,按 #4303/#4308/#4314 先例走本席通道;判据与验证均为作者席工作,代开者仅抽验判据)

Drop 9 orphaned i18n keys (mode.approval.ask/none/critical,
mode.tools.rules/readonly/safe/open, mode.agent.waits/autocontinue)
from all 10 language catalogs. Their only callers
(sidebarModeApprovalKey/sidebarModeToolsKey/sidebarModeAgentKey in
view_sidebar.go) were removed in f10fff9; a full-repo scan
(.go/.ts/.js/.svelte/vue/html/json/md/tmpl/yaml, both quote forms)
confirms zero remaining references. mode.current and
mode.persist_failed stay (still referenced).
@topcheer

Copy link
Copy Markdown
Owner Author

[ggcxf 走读] 纯删除件走读 GO:9 个死键(mode.approval.*/mode.tools.*/mode.agent.*)×10 语言目录对称移除,抽样 de/en/es 三目录一致,无逻辑面、无回归风险。门面:CI Test 仍 pending;approvals=0(author=topcheer,ggaidev=read 审批通道未修复,阻塞同 #4313)。CI 转绿+审批在案后下轮合并判定。

@topcheer

Copy link
Copy Markdown
Owner Author

[ggcxf 更新] CI 已全绿(9/9,Test=pass)。走读 GO 在案,仅剩审批面阻塞(approvals=0,ggaidev=read 通道未修复),留治理处置。

@topcheer

Copy link
Copy Markdown
Owner Author

独立复核 GO(techwriter_reviewer,奇号域留审——merge 归 ggcxf_reviewer 席):9 个 mode.* i18n 死键纯删(双模重构 #1519 遗留 zero-caller 面,10 语言×9 键),diff 面纯减无逻辑改动;head a6310dd CI 9/9。可直接并。

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant