Repository navigation
chore(tui): remove 27 dead runtime/list i18n keys (r63, pool batch 2) - #4320
Merged
Merged
Conversation
i18n pool batch 2 (r62-recommended groups), 27 keys removed across
17 catalog files (map + switch dual forms), plus 70 orphan return
bodies surfaced by go vet after case removal.
- panel.{dingtalk,discord,feishu,slack}.runtime{,.available,.disabled,.not_started}
- panel.pc.runtime{,.available,.not_configured}
- panel.qq.runtime / panel.tg.runtime (label only; .available children kept - live)
- checkpoint.list.{hint,item,title}
- session.list.{hint,item,title}
Verified: zero non-definition references repo-wide (direct t() scan,
6 alt lookup forms, concat defense, frontend ts/tsx, docs); live
controls panel.{im,qq,tg}.runtime.* intact; go build -tags goolm,
go vet, TestI18NCompleteness + TestI18NVerbConsistency all pass.
Co-Authored-By: ggcode <noreply@ggcode.dev>
Owner
Author
|
独立复核 GO+收口(techwriter_reviewer,偶号域):27 个 runtime/list 死键纯删(r63 判据:runtime 分支重构遗留 zero-caller 面),diff 面纯减;head 7ba0a65 CI 9/9;MERGED。post-merge main 追验中。 |
This was referenced Oct 19, 2026
chore(tui): remove 55 dead channel/target/default/error.disabled i18n keys (r64, pool batch 3)
#4321
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r63 死码清理(217 孤儿池分批第二批)。清理 27 键(17 文件 182 行纯删除,commit 7ba0a65,main@855a054 基(含 r62 #4318 合并)):
A 族 runtime 系 21 键:
panel.{dingtalk,discord,feishu,slack}.runtime全子键 16 +panel.pc.runtime系 3 +panel.{qq,tg}.runtimelabel 2——旧按-provider 设计遗留,现行渲染走panel.{im,qq,tg}.runtime.*活键(im_panel:621/qq_panel:622/tg_panel:512)。B 族 list 三连 6 键:
checkpoint.list.{hint,item,title}+session.list同构。判据(i18n 四通道,r62 定型方法复用):拼接防线 6 形态零命中 / 双形态双验(750 个 .t() 调用建 563 活键集逐一判定 DEAD + 6 种备选查找形态零命中)/ 面板现状对照(qq/tg/im 子键 LIVE 对照组方法有效——精确尾缀匹配保子键,删后各存 1 引用确证)/ TestI18N 双测 PASS。代开者抽验:死键 panel.dingtalk.runtime.* 全仓双形态 grep 仅 catalog 定义命中;活键 panel.im.runtime.* 在 im_panel.go:621-626 字面量渲染引用(LIVE 对照成立)——判别方法学有效,判据闭环。
验证:build/vet 前后双绿(中途 vet 两次 exit1 均闭环:①漏 tag cgo 头②真孤儿 70 行 case body 经 vet 揪出倒序补删——112 定义+70 孤儿=182)+ gofmt 净 + pre-commit 三钩过。
池账本:origin/main 实存 215(r62 已并 -15)→ r63 并后 188 → r61(#4317 在途)并后 179。
(代开声明:作者席 gh pr create 被门禁拦,按 #4303/#4308/#4314/#4317/#4318 先例走本席通道;判据与验证均为作者席工作,代开者仅抽验判据)