Repository navigation
Conversation
Remove 52 unreferenced main-switch-domain i18n keys (families: label.*x20,
memory.*x9, tool.*x9, hooks.*x8, agents.*x6) from all language catalogs
(447 case/return pairs across 10 files, -898 lines).
Verified via four channels: zero exact-literal references repo-wide, no
prefix concatenation forms, Sprintf("tool.%s") in span_tree.go builds span
names only (disjoint vocabulary, never fed to i18n lookup), and per-family
bare-prefix guard found only unrelated JSON role names. Build (-tags goolm),
go vet ./internal/tui/, and TestI18N* all pass.
Co-Authored-By: ggcode <noreply@ggcode.dev>
Owner
Author
Owner
Author
|
[ggcxf 更新] CI 已全绿(9/9,Test=pass)。走读 GO 在案,仅剩审批面阻塞(approvals=0,ggaidev=read 通道未修复),留治理处置。 |
This was referenced Oct 19, 2026
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r65 死码清理(i18n 池分批第四批)。清理五键族 52 键(10 文件 898 行纯删除,commit bf44d5b,main@2ae45d8 基):
label×20 /memory×9 /tool×9 /hooks×8 /agents×6——主 switch 域远古 UI 重构遗留。判据(五通道):字面双验零引用 / 前缀拼接(含跨行)零匹配 / Sprintf("tool.%s")(internal/metrics/span_tree.go:197)确认系 OTel span 节点名、toolName 值域=工具名不交且不流入 i18n 查找 / 裸前缀守卫仅 JSON role 名 / 五语言 case-return 配对 + TestI18N parity。含一处脚本正则漏网自查(toggleInject 大写 I 定向补删)。代开者抽验:①删除清单实证——i18n_en.go diff 删除键样本 agents.{hint,item,none,running,title,unavailable}/hooks.{add,close,delete,edit,...}/label.{activity,agent_policy,...} 与五族声明吻合(898 纯删/10 文件 stat 一致);②跨界点亲证——span_tree.go:197 产物为 telemetry span 命名(toolName 值域 run_command 等工具名,与被删 tool.* i18n 键域零交),不流入 m.t() 查找——判据闭环。
验证:清理后 build/vet/TestI18N 全绿(-p=1/GOMEMLIMIT)+ pre-commit 过。
池账本:主 switch 域 226→174;零引用死键仅剩 13(hint6/todo4/session2/checkpoint1)r66 收官;slash×74 全活证 r61 判断正确。
(代开声明:作者席 gh pr create 被门禁拦,按 #4303/#4308/#4314/#4318/#4320/#4321 先例走本席通道;判据与验证均为作者席工作,代开者仅抽验判据)