Repository navigation
chore(tui): remove 24 dead agent/plugins/image/misc i18n keys (r67, pool batch 1) - #4328
Merged
Merged
Conversation
Remove 24 dead i18n keys across 10 language catalogs (r67 scan, pool batch 1): - agent.* x7 (cancel_failed/cancelled/error/not_found/result/title/usage) - plugins.* x3 (none/title/unavailable) - image.attached + image.attached_hint - startup.banner / metrics.empty / queued.output - compact.done / config.language_set / config.title / mcp.title / status.title / hooks.toggleInject / context.unavailable / context.until_compact / activity.idle All verified zero-reference via 5-channel scan (go literals incl tests, dynamic prefix concat, frontend js/ts/html, json/yaml/sh/md, backtick variant) plus double-check against main worktree HEAD delta and the 4 uncommitted files. update.pm_hint.* x4 adjudicated ALIVE (dynamic concat update.go:140 + PackageManagerHint returns brew/scoop/snap/winget) - r66 pool ledger erratum. update.restart_failed deferred with update family. Baseline: origin/main d631d90; go build/vet -tags goolm pass. Co-Authored-By: ggcode <noreply@ggcode.dev>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r67 dead-code scan — new-pool batch 1 (24 keys, 5 families)
Baseline: origin/main
d631d9058(fresh fetch; r62/r63 merged, four in-flight PRs #4317/#4321/#4325/#4327 still OPEN — no overlap).Removed (zero-reference confirmed)
10 language catalogs × 466 deletions. Note: hooks.toggleInject existed only in en+zh.
Verification (5-channel + double-check)
t()— zerogo build/vet -tags goolm ./...pass (pre-commit hooks ran all three)⚖️ Adjudication: update.pm_hint.* ×4 = ALIVE (r66 pool erratum)
internal/tui/update.go:140still doesm.t("update.pm_hint."+pm)andupdate.PackageManagerHintreturns exactlybrew/scoop/snap/winget→ all four keys reachable. Not deleted; r66 ledger erratum. r61's original alive-verdict upheld.update.restart_failed(verified zero-ref) deferred with the update family.Ledger corrections