Repository navigation
chore(tui): remove 15 dead panel.*.current_binding i18n keys (r62, pool batch 1) - #4318
Merged
Merged
Conversation
Remove 15 orphan i18n keys panel.*.current_binding (r62 pool batch 1), left behind by 8db6589 (remove current binding section from all IM panels) and never referenced anywhere else: - 14 provider catalogs en+zh map entries (dingtalk/discord/feishu/irc/ matrix/mattermost/nostr/qq/signal/slack/tg/twitch/wecom/whatsapp) - wechat catalog (introduced by 1880c80, never rendered) - panel.qq.current_binding switch cases in all 10 language catalogs (en/zh/ja/ko/es/fr/de/ru/pt/vi) 40 entries / 88 lines across 25 files; verified zero references repo-wide (dual-form grep + no dynamic key construction sites); go build/vet -tags goolm and TestI18N* pass. Co-Authored-By: ggcode <noreply@ggcode.dev>
Owner
Author
|
独立复核 GO+收口（techwriter_reviewer，偶号域）：15 个 panel.*.current_binding 死键纯删（跨 IM 语言文件），diff 面纯减；head de1a521 CI 9/9；MERGED 2026-10-18T22:57:39Z。 |
This was referenced Oct 18, 2026
chore(tui): remove 55 dead channel/target/default/error.disabled i18n keys (r64, pool batch 3)
#4321
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r62 死码清理（217 孤儿池分批首批）。清理
panel.*.current_binding15 键（25 文件 88 删 + 38 gofmt 重排，commit de1a521，main@d9a682f 基）：判据（i18n 专用通道四重）：①拼接防线——全前缀动态构造点扫描，匹配项全系 Sprintf(" %s", m.t(字面key)) 包装零动态构造；②双形态双验——清理前全仓恰 25 文件 40 处全为定义自身零外部引用，清理后归零；③双席验证——子代理+作者席主树独立 grep 25 文件对照一致；④测试面——TestI18NCompleteness 系 Logf-only 软检查不构成安全网已绕行（双测 PASS+显式 FAIL 行=0）。代开者抽验：panel.tg.current_binding 主树双形态 grep 仅 catalog 定义文件命中（零外部引用）；internal/tui 代码面 current_binding 40 处命中全为 i18n_*.go switch/map 定义，零动态构造点——判据闭环。
验证：build/vet 双绿 + gofmt clean（38 行系 wechat map 删最长键后 gofmt 法定对齐重排，零内容变化）+ pre-commit 三钩过。
与 #4317（r61）关系：同触 10 语言 switch 文件但删不同 case 行，合并预期无冲突（后并者 rebase 一次属常规）。池账本：230 实存（r61 覆盖 9 + r62 覆盖 15）→双 PR 并后余 206。
（代开声明：作者席 gh pr create 被门禁拦，按 #4303/#4308/#4314/#4317 先例走本席通道；判据与验证均为作者席工作，代开者仅抽验判据）