Repository navigation
fix(i18n): remove dead duplicate entries of 6 keys (#192) - #197
Merged
kosarko merged 1 commit intoNov 12, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the duplicate-translation cleanup.
No open issues 🎉
What changed in this PR
Removes dead duplicate translations to address #192, preventing sync-i18n from overwriting active Czech text while preserving current UI messages.
Changes:
- Removes the first definition of six duplicated keys from both translation files.
- Removes the corresponding Czech source comments.
- Preserves the active definitions, including messages with
{{fileName}}placeholders.
| File | Description |
|---|---|
src/assets/i18n/en.json5 |
Removes six shadowed English translation entries. |
src/assets/i18n/cs.json5 |
Removes six shadowed Czech entries and their source comments. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192.
Problem description
Six i18n keys were defined twice in
en.json5andcs.json5. JSON5 uses the last entry, butsync-i18npaired the live English entry with the dead Czech one and overwrote the live Czech text. This broke #167 (error.save.messagelost{{fileName}}).Analysis
Deleted the dead first entry of each key, plus its Czech source comment (29 deletions, 0 insertions):
admin.update-config.success.save.title,.success.save.message,.error.save.title,.error.save.message,.file-info.modified, anditem.preview.dc.identifier.other.Problems
Sync verification
yarn run sync-i18n -t src/assets/i18n/cs.json5 -i— gate PASSEDCopilot review