Skip to content

fix(i18n): remove dead duplicate entries of 6 keys (#192) - #197

Merged
kosarko merged 1 commit into
clarin-v7from
192-duplicate-i18n-keys-in-enjson5csjson5-break-sync-i18n
Nov 12, 2026
Merged

kosarko merged 1 commit into
clarin-v7from
192-duplicate-i18n-keys-in-enjson5csjson5-break-sync-i18n

Conversation

@amadulhaxxani

Copy link
Copy Markdown

Fixes #192.

Problem description

Six i18n keys were defined twice in en.json5 and cs.json5. JSON5 uses the last entry, but sync-i18n paired the live English entry with the dead Czech one and overwrote the live Czech text. This broke #167 (error.save.message lost {{fileName}}).

Analysis

Deleted the dead first entry of each key, plus its Czech source comment (29 deletions, 0 insertions): admin.update-config.success.save.title, .success.save.message, .error.save.title, .error.save.message, .file-info.modified, and item.preview.dc.identifier.other.

Problems

Sync verification

  • Ran yarn run sync-i18n -t src/assets/i18n/cs.json5 -i — gate PASSED

Copilot review

  • Requested review from Copilot

@amadulhaxxani amadulhaxxani linked an issue Nov 2, 2026 that may be closed by this pull request
Copilot AI balanced review requested due to automatic review settings November 2, 2026 10:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the duplicate-translation cleanup.

No open issues 🎉

What changed in this PR

Removes dead duplicate translations to address #192, preventing sync-i18n from overwriting active Czech text while preserving current UI messages.

Changes:

  • Removes the first definition of six duplicated keys from both translation files.
  • Removes the corresponding Czech source comments.
  • Preserves the active definitions, including messages with {{fileName}} placeholders.
File Description
src/​assets/​i18n/​en.json5 Removes six shadowed English translation entries.
src/​assets/​i18n/​cs.json5 Removes six shadowed Czech entries and their source comments.

Review effort: Balanced

@kuchtiak-ufal kuchtiak-ufal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kosarko
kosarko merged commit 28c0457 into clarin-v7 Nov 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate i18n keys in en.json5/cs.json5 break sync-i18n

4 participants