Repository navigation
test(client): scope fleet_accounted to Unix, where the desktop uses it - #688
Merged
Merged
Conversation
#684's longer stop grace did not fix the Windows native job: the owned EOF never arrives there at any grace. The desktop starts the accounted Fleet only on Unix (src-tauri commands.rs); Windows keeps Fleet::start, whose stream EOF tests/fleet.rs covers and which passes on Windows. Gate the file like its production caller and restore the author's 100 ms grace. The Windows accounted stop path is tracked separately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The longer grace from #684 didn't fix the to-main-5 Windows native job. On the second run (41151373830),
accounted_local_and_peer_keep_frames_controls_and_eofstill timed out waiting for the owned EOF. On Windows it never arrives at any grace, so my earlier theory was wrong.The desktop starts the accounted Fleet only on Unix (
client/src-tauri/src/commands.rs,#[cfg(unix)] Fleet::start_accounted). Windows keepsFleet::start, whose stream EOFtests/fleet.rscovers and which passes on Windows CI. The file's other test was already#[cfg(unix)].This gates the whole file with
#![cfg(unix)], like its production caller, and restores the author's 100 ms grace. A bead tracks the Windows accounted stop path before Windows adopts it.Linux: both tests pass. Windows all-target cross-clippy for client/core passes; fmt is clean.
🤖 Generated with Claude Code