Repository navigation
fix(player): Dolby passthrough on Safari (iPad stuck on Buffering) - #11
Merged
Merged
Conversation
…y through instead of re-encoding it An iPad sat black on « Buffering » on a WEB HEVC Main 10 + E-AC-3 5.1 MKV: Tier B mounted, no error, nothing played. The video feed waits on the libav decode + AudioEncoder re-encode of the audio. msePlaysAudio() asks MSE about ac-3 / ec-3 (Safari yes, Chrome no) and pickTier, Tier B and Tier E pass the track through when it says yes; Mediabunny writes the dac3 / dec3 boxes. iPad bench gains a clip shaped like the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An iPad (Safari 26.6.1) sat on a black « Buffering » on The Price of Confession S01E02: MKV, HEVC Main 10 1080p, five E-AC-3 5.1 tracks. Server side: three manifest fetches, no remux, no playback-error, so Tier B mounted and stalled without an error. The video feed waits on the libav.js decode + AudioEncoder re-encode of the audio.
Safari plays AC-3 / E-AC-3 itself (it said so in its Iris-Caps).
msePlaysAudio()asks MSE aboutac-3/ec-3; pickTier, Tier B and Tier E pass the track through when it says yes. Mediabunny writes the dac3 / dec3 boxes. Chrome answers no and keeps re-encoding.Tests:
bun run checkclean,bun run test592 green.Not reproduced before the fix: emulated WebKit plays the old path too. Validate on the real iPad after deploy.