Repository navigation
Conversation
With Voltage's Developer ID in the repository secrets, the release workflow signs Buzz.app for notarization and then notarizes the .dmg. The signing uses the hardened runtime, secure timestamps, and entitlements for the microphone, GStreamer's ORC and the bundled Node's JIT. The workflow then staples the ticket and checks that Gatekeeper accepts the app as notarized. Without the secrets, packaging signs ad hoc as before, and a release run warns. check-macos-dmg.sh runs a hardened build's self-check as signed. dyld ignores DYLD_ variables under the hardened runtime, so the library trace runs on a copy signed ad hoc. Refs #87 Signed-off-by: Tee8z <tee8z@protonmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #87: the macOS part. The Linux part is #121.
Change
package-macos.sh. WithMACOS_SIGN_IDENTITYset, the script signs every Mach-O and then the bundle. It uses the hardened runtime and secure timestamps. It also signs the.dmg. Without the variable, the script signs ad hoc as before. One change applies to both paths: the bundle is now signed without--deep, because each nested Mach-O is already signed first, and--deepwould put the app's entitlements on nested code too.packaging/macos/):allow-unsigned-executable-memory, because GStreamer's ORC maps RWX memory withoutMAP_JIT.osx-entitlements.plist. This excludesget-task-allow, which notarization rejects, and the native-addon and DYLD entitlements, which the plugins do not need.notarize-macos.sh. Submits withnotarytooland an App Store Connect API key. If Apple does not accept the submission, the script prints Apple's log and fails. Otherwise it staples the ticket and validates it. It then requiresspctlto accept the image, and to reportsource=Notarized Developer IDfor the app inside.check-macos-dmg.sh. dyld ignoresDYLD_PRINT_LIBRARIESunder the hardened runtime. So a signed build first runs--gst-checkas signed: this proves that the entitlements and library validation hold. The library trace then runs on a copy signed ad hoc.MACOS_DEVELOPER_ID_P12is present, a temporary keychain is created with the Developer ID. The workflow then packages, checks, notarizes and uploads the stapled.dmg. Without the secret, the build stays ad hoc. On a release dispatch the workflow then emits a warning, so a release never loses notarization without notice.Secrets needed (none are configured yet)
MACOS_DEVELOPER_ID_P12.p12of the Developer ID Application certificate and its private keyMACOS_DEVELOPER_ID_P12_PASSWORD.p12passwordAPPLE_API_KEY_P8.p8contents)APPLE_API_KEY_IDAPPLE_API_ISSUERValidation
--deepchange, throughcheck-macos-dmg.sh.Buzz GPUI Releaseworkflow. The macOS legs then sign, run the hardened self-check, and notarize. This PR stays a draft until those legs pass.voltage/remote-agents.md.