Skip to content

sim: fix TCU tile-buffer response matching past 65536 requests #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eyoon1131 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sim: fix TCU tile-buffer response matching past 65536 requests #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sim/simx/tcu/tcu_tbuf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,10 @@ class TcuTbuf::Impl {
auto& buf = bufs_.at(s);
if (buf.pending_q_.empty()) continue;
uint64_t addr = buf.pending_q_.front();
uint32_t sub_tag = buf.next_tag_++;
// Mask at generation: pack_tag() masks to kSubTagMask on the wire, so an
// unmasked key here stops matching the returned tag once next_tag_ passes
// 0xFFFF -- the response is then dropped and the inflight entry never clears.
uint32_t sub_tag = (buf.next_tag_++) & kSubTagMask;
uint32_t tag = pack_tag(s, sub_tag);
MemReq m(MemOp::LD, addr, /*data*/nullptr, /*byteen*/0, tag, /*hart_id*/0, /*uuid*/0);
m.flags.local = 1; // TCU TBUF reads from LMEM
Expand Down
Loading