afu: route the command processor through the bank adapter on multi-port shells - #422
Merged
Merged
Conversation
…rt shells The XRT shell merged the CP's device master with Vortex at AXI port 0, downstream of VX_mem_to_axi, so every CP transfer left on m_axi_mem_0 whichever bank owned the line. It went unnoticed because xrtsim backed all ports with one RAM and the HBM platforms build the merged single port. With several ports the CP now enters VX_mem_to_axi through VX_membus_from_axi as one more input port, so bank selection applies to the CP and Vortex alike; the single-port shell keeps its original structure. VX_afu_axi_limit holds port 0 to one read and one write in flight, the policy the 2:1 arbiter used to impose, which keeps cycle counts unchanged. xrtsim gives each AXI port its own memory, so a request on the wrong port misses instead of finding the data in a shared image. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VX_mem_to_axi, so every CP transfer left onm_axi_mem_0whichever bank owned the line. This went unnoticed because xrtsim backed all ports with one RAM and the HBM platforms build the merged single port; with one memory per port (a per-bank Questa testbench, or a per-channel HBM build) only bank 0 receives the kernel image.VX_mem_to_axithroughVX_membus_from_axias one more input port, so bank selection applies to the CP and Vortex alike (the structure the OPAE shell already uses). The single-port shell keeps its original logic verbatim.VX_afu_axi_limitholds port 0 to one read and one write in flight, the policy the 2:1 arbiter used to impose, so cycle counts are unchanged.Validation
ci/fpga_gate.py -b top(AFU top, 2 banks): PASS, Fmax 259.1 MHz (baseline 252.6), LUT +0.5%, FF +1.2%, LUTRAM/BRAM/DSP unchanged. The single-port branch is the original logic and was not re-synthesized.Notes
INTERLEAVE=1is a prerequisite for a per-channel HBM build and is not part of this change.🤖 Generated with Claude Code