Repository navigation
fix: avoid optimized OpenSSL crashes on Windows ARM64 - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh Windows ARM64 builds crash with an access violation during a DTLS handshake on current main, including the exact Node 20 static-OpenSSL release build. Add a vcpkg overlay triplet that builds OpenSSL C code with /Od, retaining static libraries, assembly implementations, and optimized addon/libdatachannel code. Include the overlay in the cache key so optimized dependencies cannot be reused.
Validation: the isolated ARM64 comparison passes all 65 unit tests, API/type checks, and a two-peer data-channel exchange: https://github.com/webrtc-node/webrtc/actions/runs/38153597652. The unchanged release-build control crashes: https://github.com/webrtc-node/webrtc/actions/runs/38154096480. Current-facade tests with the existing stable binary pass on Node 20, 22, and 24: https://github.com/webrtc-node/webrtc/actions/runs/38153118916. Normal required CI and CodeQL must pass before merging. OpenSSL C-code performance is the tradeoff; no checks are disabled.