tutorial hierarchical zarr stores#361
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
✅ Preview is ready!
↩️ Previous: ⚡️ 🤖 Powered by surge-preview |
|||||||||||||||
| @@ -0,0 +1,251 @@ | |||
| { | |||
There was a problem hiding this comment.
learning objectives:
- should this be just "hierarchical structure" (without the "group" before it)?
Reply via ReviewNB
| @@ -0,0 +1,251 @@ | |||
| { | |||
There was a problem hiding this comment.
I think you can use
`{note} We selected consolidated=True, Zarr ...`
to get something more noticeable (see https://mystmd.org/guide/admonitions)
Looks like reviewnb may butcher the markdown, this should be a triple quote block (but could also be a ::: block if that setting is enabled in the config)
Reply via ReviewNB
| @@ -0,0 +1,251 @@ | |||
| { | |||
There was a problem hiding this comment.
do we need to explain the different args here? To be clear, I believe the answer to this depends on your target audience. If this is for advanced users not explaining chunks={} or engine="zarr" should be fine
Reply via ReviewNB
| @@ -0,0 +1,251 @@ | |||
| { | |||
There was a problem hiding this comment.
this could be a bit clearer... DataTree abstracts the backend away, such that it shouldn't matter where this is coming from (local vs cloud, or zarr vs in-memory).
And I would call the latter access method "attribute syntax" instead of "method" because for python the difference between the two is that a method is a callable with the first parameter bound to the instance.
Reply via ReviewNB
| @@ -0,0 +1,251 @@ | |||
| { | |||
There was a problem hiding this comment.
I tend to use the dict-like syntax for the entire thing: precip_dt["observed/precipitation"]. I guess that's a matter of taste (as in, totally arbitrary) as long as there's no conflict with attributes / methods / accessors.
Reply via ReviewNB
2 participants
cc @VeckoTheGecko, @ianhi and @keewis