Repository navigation
refactor(spec): use local diagnostics in reports and CLI - #841
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The stacked refactor still needs integration review and authoritative final-head CI verification after its prerequisites merge and it is retargeted.
No open issues 🎉
What changed in this PR
This phase of #819 moves report and CLI diagnostics into an invocation-local generation result, reducing reliance on mutable registry state while preserving public APIs and compatibility publication.
Changes:
- Capture local diagnostics and reuse validation when operation traversal is unchanged.
- Update reports and the CLI to consume the result while preserving standalone collection and runtime serialization behavior.
- Add characterization tests and document diagnostic ownership and call flow.
| File | Description |
|---|---|
tests/test_spec_report_local_diagnostics.py |
Tests diagnostic isolation, validation counts, warning parity, and CLI behavior. |
src/azure_functions_openapi/spec.py |
Produces local generation results and conditionally reuses validation. |
src/azure_functions_openapi/cli.py |
Consumes local results while retaining plain-document compatibility. |
src/azure_functions_openapi/_generation_result.py |
Defines the internal frozen generation-result container. |
DESIGN.md |
Documents diagnostic ownership and before/after generation flow. |
Review effort: Balanced
Base automatically changed from
refactor/spec-local-generation-diagnostics-819
to
main
October 26, 2026 10:57
yeongseon
force-pushed
the
refactor/spec-report-cli-local-diagnostics-819
branch
from
October 26, 2026 10:59
273ef5b to
3603b5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use diagnostics from each specification-generation call in reports and the CLI instead of rereading mutable registry state.
Changes
DESIGN.mdwith diagnostic ownership and the generation flow.Validation
make format-check,make lint,make typecheck,make test,make check-all,make build, andmake perfpassed.Related Issues
Refs #819
Stacked on #840, which is stacked on #838. Retarget and rebase after both prerequisite PRs merge; this is not the closing PR.