fix: app icon dom nesting

[benlife5]

These icons are passes as the label for the <cta>, which renders as the child of an anchor tag, so they shouldn't themselves be anchor tags

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 59ad22de-9a36-4a8d-8106-ea5592c61aba

📥 Commits

Reviewing files that changed from the base of the PR and between 836f547 and c67312b.

📒 Files selected for processing (4)

• packages/visual-editor/src/components/assets/presetImages/AppGalleryButton.tsx
• packages/visual-editor/src/components/assets/presetImages/AppStoreButton.tsx
• packages/visual-editor/src/components/assets/presetImages/GalaxyStoreButton.tsx
• packages/visual-editor/src/components/assets/presetImages/GooglePlayButton.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

The four store badge components now accept span attributes and render a <span role="img"> instead of an anchor. They retain their translated accessible labels and size options. The changes also remove anchor focus-ring and focus-visible outline styles.

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to c6731

The badge change addresses nested links without an identified regression. It is mergeable after normal checks.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to c6731

The badges become non-interactive images inside existing links. No security regression was identified in the checked usage. Compatibility for consumers outside the repository remains unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The demonstrated exposure is browser-side badge rendering and its exported preset-node contract. In the checked CTA path, the change does not grant badge content additional navigation authority; destination ownership remains with the enclosing interaction component.

Trust Boundaries and Controls

• observed — CTA remains the interaction owner. Its unchanged link branch supplies the destination, click handler, target, and rel="noopener noreferrer" when openInNewTab is enabled. Its disabled branch retains event cancellation. These behaviors are not delegated to the badge spans.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title, “fix: app icon dom nesting,” clearly describes the change to prevent app icons from rendering as nested anchors.
Description check	✅ Passed	The description explains why the app icons should not render as anchors inside the CTA anchor.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}